Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: media/base/text_renderer.cc

Issue 151103005: TextRenderer only pushes new cues downstream (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: added text ranges utility and unit test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/text_renderer.cc
diff --git a/media/base/text_renderer.cc b/media/base/text_renderer.cc
index 63ad27a2ba72bbbb62288ab48626df98e9b7e6b1..2e13885a53607b0f3c78b253bf630b7d7b81a7ef 100644
--- a/media/base/text_renderer.cc
+++ b/media/base/text_renderer.cc
@@ -90,6 +90,7 @@ void TextRenderer::Flush(const base::Closure& callback) {
for (TextTrackStateMap::iterator itr = text_track_state_map_.begin();
itr != text_track_state_map_.end(); ++itr) {
pending_eos_set_.insert(itr->first);
+ itr->second->text_ranges_.Flush();
}
DCHECK_EQ(pending_eos_set_.size(), text_track_state_map_.size());
callback.Run();
@@ -306,12 +307,15 @@ void TextRenderer::CueReady(
}
base::TimeDelta start = text_cue->timestamp();
- base::TimeDelta end = start + text_cue->duration();
- state->text_track->addWebVTTCue(start, end,
- text_cue->id(),
- text_cue->text(),
- text_cue->settings());
+ if (state->text_ranges_.AddCue(start)) {
+ base::TimeDelta end = start + text_cue->duration();
+
+ state->text_track->addWebVTTCue(start, end,
+ text_cue->id(),
+ text_cue->text(),
+ text_cue->settings());
+ }
if (state_ == kPlaying) {
Read(state, text_stream);

Powered by Google App Engine
This is Rietveld 408576698