Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1511023006:
Use the new Mojo EDK in chrome. (Closed)
|
Created:
5 years ago by jam Modified:
3 years, 9 months ago CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse the new Mojo EDK in chrome.
--use-old-edk can override this temporarily.
BUG=561803
Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7
Cr-Commit-Position: refs/heads/master@{#364599}
Committed: https://crrev.com/9c86764dba8f7c16f2229b4f8fdb544f3da97582
Cr-Commit-Position: refs/heads/master@{#365887}
Committed: https://crrev.com/0974022a2da064528789c261204c15f6adcd4365
Cr-Commit-Position: refs/heads/master@{#366047}
Committed: https://crrev.com/b046f171fcf76f0b18678e35dc1c50be195fb4f3
Cr-Commit-Position: refs/heads/master@{#366752}
Patch Set 1 : #Patch Set 2 : reupload after revert #Patch Set 3 : reupload #Patch Set 4 : reupload after revert #Patch Set 5 : try again after asan fix landed #Patch Set 6 : try again after tsan fix and suppression #Messages
Total messages: 81 (47 generated)
Patchset #1 (id:1) has been deleted
jam@chromium.org changed reviewers: + sky@chromium.org
Patchset #1 (id:20001) has been deleted
LGTM
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511023006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511023006/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511023006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511023006/40001
Message was sent while issue was closed.
Committed patchset #1 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 ========== to ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:40001) has been created in https://codereview.chromium.org/1513373004/ by jam@chromium.org. The reason for reverting is: Seeing flake on some bots.
Message was sent while issue was closed.
Description was changed from ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} ========== to ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} ==========
The CQ bit was checked by jam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org Link to the patchset: https://codereview.chromium.org/1511023006/#ps60001 (title: "reupload after revert")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511023006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511023006/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511023006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511023006/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #3 (id:80001) has been deleted
The CQ bit was checked by jam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org Link to the patchset: https://codereview.chromium.org/1511023006/#ps60001 (title: "reupload after revert")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511023006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511023006/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511023006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511023006/60001
The CQ bit was unchecked by jam@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511023006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511023006/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #6 (id:160001) has been deleted
Patchset #5 (id:140001) has been deleted
Patchset #4 (id:120001) has been deleted
Patchset #3 (id:100001) has been deleted
The CQ bit was checked by jam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org Link to the patchset: https://codereview.chromium.org/1511023006/#ps180001 (title: "reupload")
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511023006/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511023006/180001
Message was sent while issue was closed.
Description was changed from ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} ========== to ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:180001)
Message was sent while issue was closed.
Description was changed from ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} ========== to ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} Committed: https://crrev.com/9c86764dba8f7c16f2229b4f8fdb544f3da97582 Cr-Commit-Position: refs/heads/master@{#365887} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/9c86764dba8f7c16f2229b4f8fdb544f3da97582 Cr-Commit-Position: refs/heads/master@{#365887}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:180001) has been created in https://codereview.chromium.org/1532243002/ by jam@chromium.org. The reason for reverting is: Reverting because there are leaks in unit tests. I'll fix those and reland..
Message was sent while issue was closed.
Description was changed from ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} Committed: https://crrev.com/9c86764dba8f7c16f2229b4f8fdb544f3da97582 Cr-Commit-Position: refs/heads/master@{#365887} ========== to ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} Committed: https://crrev.com/9c86764dba8f7c16f2229b4f8fdb544f3da97582 Cr-Commit-Position: refs/heads/master@{#365887} ==========
The CQ bit was checked by jam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org Link to the patchset: https://codereview.chromium.org/1511023006/#ps220001 (title: "try again after asan fix landed")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511023006/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511023006/220001
Message was sent while issue was closed.
Description was changed from ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} Committed: https://crrev.com/9c86764dba8f7c16f2229b4f8fdb544f3da97582 Cr-Commit-Position: refs/heads/master@{#365887} ========== to ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} Committed: https://crrev.com/9c86764dba8f7c16f2229b4f8fdb544f3da97582 Cr-Commit-Position: refs/heads/master@{#365887} ==========
Message was sent while issue was closed.
Committed patchset #5 (id:220001)
Message was sent while issue was closed.
Description was changed from ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} Committed: https://crrev.com/9c86764dba8f7c16f2229b4f8fdb544f3da97582 Cr-Commit-Position: refs/heads/master@{#365887} ========== to ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} Committed: https://crrev.com/9c86764dba8f7c16f2229b4f8fdb544f3da97582 Cr-Commit-Position: refs/heads/master@{#365887} Committed: https://crrev.com/0974022a2da064528789c261204c15f6adcd4365 Cr-Commit-Position: refs/heads/master@{#366047} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/0974022a2da064528789c261204c15f6adcd4365 Cr-Commit-Position: refs/heads/master@{#366047}
Message was sent while issue was closed.
thakis@chromium.org changed reviewers: + thakis@chromium.org
Message was sent while issue was closed.
TSan reports potential deadlocks in many many tests after this: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20TSan%20Tests... Please take a look. If this can't be fixed quickly, please revert.
Message was sent while issue was closed.
In addition to that, valgrind also reports an uninitialized read in mojo::edk::PlatformChannelWrite: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28v...
Message was sent while issue was closed.
On 2015/12/18 14:40:23, Nico (office move Wed Thu Fri) wrote: > In addition to that, valgrind also reports an uninitialized read in > mojo::edk::PlatformChannelWrite: > > http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28v... Thanks for the pointers.I'll revert now and look later.
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:220001) has been created in https://codereview.chromium.org/1539933002/ by jam@chromium.org. The reason for reverting is: Revert while I investigate TSAN warnings to see if they're legit or need to be suppressed..
Message was sent while issue was closed.
Description was changed from ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} Committed: https://crrev.com/9c86764dba8f7c16f2229b4f8fdb544f3da97582 Cr-Commit-Position: refs/heads/master@{#365887} Committed: https://crrev.com/0974022a2da064528789c261204c15f6adcd4365 Cr-Commit-Position: refs/heads/master@{#366047} ========== to ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} Committed: https://crrev.com/9c86764dba8f7c16f2229b4f8fdb544f3da97582 Cr-Commit-Position: refs/heads/master@{#365887} Committed: https://crrev.com/0974022a2da064528789c261204c15f6adcd4365 Cr-Commit-Position: refs/heads/master@{#366047} ==========
The CQ bit was checked by jam@chromium.org
The CQ bit was unchecked by jam@chromium.org
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511023006/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511023006/240001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org Link to the patchset: https://codereview.chromium.org/1511023006/#ps240001 (title: "try again after tsan fix and suppression")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511023006/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511023006/240001
Message was sent while issue was closed.
Description was changed from ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} Committed: https://crrev.com/9c86764dba8f7c16f2229b4f8fdb544f3da97582 Cr-Commit-Position: refs/heads/master@{#365887} Committed: https://crrev.com/0974022a2da064528789c261204c15f6adcd4365 Cr-Commit-Position: refs/heads/master@{#366047} ========== to ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} Committed: https://crrev.com/9c86764dba8f7c16f2229b4f8fdb544f3da97582 Cr-Commit-Position: refs/heads/master@{#365887} Committed: https://crrev.com/0974022a2da064528789c261204c15f6adcd4365 Cr-Commit-Position: refs/heads/master@{#366047} ==========
Message was sent while issue was closed.
Committed patchset #6 (id:240001)
Message was sent while issue was closed.
Description was changed from ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} Committed: https://crrev.com/9c86764dba8f7c16f2229b4f8fdb544f3da97582 Cr-Commit-Position: refs/heads/master@{#365887} Committed: https://crrev.com/0974022a2da064528789c261204c15f6adcd4365 Cr-Commit-Position: refs/heads/master@{#366047} ========== to ========== Use the new Mojo EDK in chrome. --use-old-edk can override this temporarily. BUG=561803 Committed: https://crrev.com/710285b713a25f10f641e0d530c77cc3e4151df7 Cr-Commit-Position: refs/heads/master@{#364599} Committed: https://crrev.com/9c86764dba8f7c16f2229b4f8fdb544f3da97582 Cr-Commit-Position: refs/heads/master@{#365887} Committed: https://crrev.com/0974022a2da064528789c261204c15f6adcd4365 Cr-Commit-Position: refs/heads/master@{#366047} Committed: https://crrev.com/b046f171fcf76f0b18678e35dc1c50be195fb4f3 Cr-Commit-Position: refs/heads/master@{#366752} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/b046f171fcf76f0b18678e35dc1c50be195fb4f3 Cr-Commit-Position: refs/heads/master@{#366752}
Message was sent while issue was closed.
Patchset #7 (id:260001) has been deleted |
