Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1511023002:
Do not reuse webcontent which associates constrained login page. (Closed)
|
Created:
5 years ago by gogerald1 Modified:
3 years, 5 months ago Reviewers:
Roger Tawa OOO till Jul 10th CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDo not reuse webcontent which associates constrained login page.
Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct (ACCESS_POINT_SETTINGS), but triggerd this problem when the login page is opened in avatar bubble (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/webui/options/sync_setup_handler.cc&l=384).
BUG=567794
Committed: https://crrev.com/be041f3e7506d634d80f9bdb4323b118efd59554
Cr-Commit-Position: refs/heads/master@{#364188}
Patch Set 1 : #Patch Set 2 : #
Total comments: 1
Patch Set 3 : #Messages
Total messages: 30 (23 generated)
Description was changed from ========== address crash BUG= ========== to ========== Show inline confirmation UI for sync settings if login page was not opened in browser window. Show inline confirmation UI for sync settings if login page was not opened in browser window. BUG=567794 ==========
gogerald@chromium.org changed reviewers: + rogerta@chromium.org
Description was changed from ========== Show inline confirmation UI for sync settings if login page was not opened in browser window. Show inline confirmation UI for sync settings if login page was not opened in browser window. BUG=567794 ========== to ========== Show inline confirmation UI for sync settings if login page was not opened in browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN, so this problem has not been triggered. However, from the code, the login in page could be opened in avatar bubble or browser window (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ==========
Patchset #1 (id:1) has been deleted
Description was changed from ========== Show inline confirmation UI for sync settings if login page was not opened in browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN, so this problem has not been triggered. However, from the code, the login in page could be opened in avatar bubble or browser window (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ========== to ========== Do not reuse webcontent does not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN, so this problem has not been triggered. However, from the code, the login in page could be opened in avatar bubble or browser window (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ==========
Description was changed from ========== Do not reuse webcontent does not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN, so this problem has not been triggered. However, from the code, the login in page could be opened in avatar bubble or browser window (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ========== to ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN, so this problem has not been triggered. However, from the code, the login in page could be opened in avatar bubble or browser window (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ==========
Description was changed from ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN, so this problem has not been triggered. However, from the code, the login in page could be opened in avatar bubble or browser window (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ========== to ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN, so this problem has not been triggered. However, the login in page could be opened in avatar bubble or browser window (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ==========
Description was changed from ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN, so this problem has not been triggered. However, the login in page could be opened in avatar bubble or browser window (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ========== to ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is bug for source from settings. After landing https://codereview.chromium.org/1473543002/ the access point is corrected, but revealed this problem. BUG=567794 ==========
Description was changed from ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is bug for source from settings. After landing https://codereview.chromium.org/1473543002/ the access point is corrected, but revealed this problem. BUG=567794 ========== to ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is bug for source from settings. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct, but revealed this problem. BUG=567794 ==========
Description was changed from ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is bug for source from settings. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct, but revealed this problem. BUG=567794 ========== to ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug for source from settings. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct, but revealed this problem. BUG=567794 ==========
Description was changed from ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug for source from settings. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct, but revealed this problem. BUG=567794 ========== to ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug for source from settings. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct, but revealed this problem when the login page is opened in avatar bubble. BUG=567794 ==========
Description was changed from ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug for source from settings. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct, but revealed this problem when the login page is opened in avatar bubble. BUG=567794 ========== to ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug for source from settings. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct (ACCESS_POINT_SETTINGS), but revealed this problem when the login page is opened in avatar bubble. BUG=567794 ==========
Description was changed from ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug for source from settings. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct (ACCESS_POINT_SETTINGS), but revealed this problem when the login page is opened in avatar bubble. BUG=567794 ========== to ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug for source from settings. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct (ACCESS_POINT_SETTINGS), but revealed this problem when the login page is opened in avatar bubble (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ==========
Description was changed from ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug for source from settings. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct (ACCESS_POINT_SETTINGS), but revealed this problem when the login page is opened in avatar bubble (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ========== to ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug for source from settings. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct (ACCESS_POINT_SETTINGS), but triggerd this problem when the login page is opened in avatar bubble (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ==========
Description was changed from ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug for source from settings. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct (ACCESS_POINT_SETTINGS), but triggerd this problem when the login page is opened in avatar bubble (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ========== to ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct (ACCESS_POINT_SETTINGS), but triggerd this problem when the login page is opened in avatar bubble (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ==========
Hi Roger, please help review this changes. Ganggui,
Description was changed from ========== Do not reuse webcontent which is not associated with the browser window. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct (ACCESS_POINT_SETTINGS), but triggerd this problem when the login page is opened in avatar bubble (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ========== to ========== Do not reuse webcontent which is constrained. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct (ACCESS_POINT_SETTINGS), but triggerd this problem when the login page is opened in avatar bubble (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ==========
Description was changed from ========== Do not reuse webcontent which is constrained. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct (ACCESS_POINT_SETTINGS), but triggerd this problem when the login page is opened in avatar bubble (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ========== to ========== Do not reuse webcontent which associates constrained login page. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct (ACCESS_POINT_SETTINGS), but triggerd this problem when the login page is opened in avatar bubble (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ==========
lgtm https://codereview.chromium.org/1511023002/diff/40001/chrome/browser/ui/sync/... File chrome/browser/ui/sync/one_click_signin_sync_starter.cc (right): https://codereview.chromium.org/1511023002/diff/40001/chrome/browser/ui/sync/... chrome/browser/ui/sync/one_click_signin_sync_starter.cc:540: bool is_constrained = (constrained_key == "1") ? true : false; Nit: can do: bool is_constrained = (constrained_key == "1");
The CQ bit was checked by gogerald@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rogerta@chromium.org Link to the patchset: https://codereview.chromium.org/1511023002/#ps60001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511023002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511023002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by gogerald@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511023002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511023002/60001
Message was sent while issue was closed.
Description was changed from ========== Do not reuse webcontent which associates constrained login page. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct (ACCESS_POINT_SETTINGS), but triggerd this problem when the login page is opened in avatar bubble (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ========== to ========== Do not reuse webcontent which associates constrained login page. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct (ACCESS_POINT_SETTINGS), but triggerd this problem when the login page is opened in avatar bubble (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Do not reuse webcontent which associates constrained login page. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct (ACCESS_POINT_SETTINGS), but triggerd this problem when the login page is opened in avatar bubble (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 ========== to ========== Do not reuse webcontent which associates constrained login page. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct (ACCESS_POINT_SETTINGS), but triggerd this problem when the login page is opened in avatar bubble (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...). BUG=567794 Committed: https://crrev.com/be041f3e7506d634d80f9bdb4323b118efd59554 Cr-Commit-Position: refs/heads/master@{#364188} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/be041f3e7506d634d80f9bdb4323b118efd59554 Cr-Commit-Position: refs/heads/master@{#364188} |
