third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h - Issue 1511003003: Use refs for non-null GraphicsContext, Scrollbar, etc. in scrollbar related code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h

Issue 1511003003: Use refs for non-null GraphicsContext, Scrollbar, etc. in scrollbar related code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ScrollbarRemove

Patch Set: yet another mac fix Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollbarThemeNonMacCommon.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h

index c9087c69739672216ed86c823269d9af8009aebc..0af2c0444fc2d0c34e8b2978d7d5b034e8dd9665 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h

+++ b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h

@@ -45,21 +45,22 @@ public:

int scrollbarMargin() const override;

bool usesOverlayScrollbars() const override;

- int thumbPosition(const ScrollbarThemeClient*) override;

- int thumbLength(const ScrollbarThemeClient*) override;

+ int thumbPosition(const ScrollbarThemeClient&) override;

+ int thumbLength(const ScrollbarThemeClient&) override;

- bool hasButtons(const ScrollbarThemeClient*) override { return false; }

- bool hasThumb(const ScrollbarThemeClient*) override;

+ bool hasButtons(const ScrollbarThemeClient&) override { return false; }

+ bool hasThumb(const ScrollbarThemeClient&) override;

- IntRect backButtonRect(const ScrollbarThemeClient*, ScrollbarPart, bool painting = false) override;

- IntRect forwardButtonRect(const ScrollbarThemeClient*, ScrollbarPart, bool painting = false) override;

- IntRect trackRect(const ScrollbarThemeClient*, bool painting = false) override;

- int thumbThickness(const ScrollbarThemeClient*) override;

+ IntRect backButtonRect(const ScrollbarThemeClient&, ScrollbarPart, bool painting = false) override;

+ IntRect forwardButtonRect(const ScrollbarThemeClient&, ScrollbarPart, bool painting = false) override;

+ IntRect trackRect(const ScrollbarThemeClient&, bool painting = false) override;

+ int thumbThickness(const ScrollbarThemeClient&) override;

+ int thumbThickness() { return m_thumbThickness; }

- void paintThumb(GraphicsContext*, const ScrollbarThemeClient*, const IntRect&) override;

- ScrollbarPart hitTest(const ScrollbarThemeClient*, const IntPoint&) override;

+ void paintThumb(GraphicsContext&, const ScrollbarThemeClient&, const IntRect&) override;

+ ScrollbarPart hitTest(const ScrollbarThemeClient&, const IntPoint&) override;

- static ScrollbarTheme* mobileTheme();

+ static ScrollbarThemeOverlay& mobileTheme();

private:

int m_thumbThickness;