third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.h - Issue 1511003003: Use refs for non-null GraphicsContext, Scrollbar, etc. in scrollbar related code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.h

Issue 1511003003: Use refs for non-null GraphicsContext, Scrollbar, etc. in scrollbar related code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ScrollbarRemove

Patch Set: yet another mac fix Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.mm ('k') | third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.h

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.h b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.h

index f14f4b5cad99c0cdb3d0e4c9c485a8d1747f2d95..6d752e35b99c729b7afd2fa4e7d2099e3f32fc79 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.h

+++ b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.h

@@ -40,15 +40,15 @@ public:

protected:

bool shouldRepaintAllPartsOnInvalidation() const override;

- bool hasButtons(const ScrollbarThemeClient*) override { return false; }

- bool hasThumb(const ScrollbarThemeClient*) override { return true; }

+ bool hasButtons(const ScrollbarThemeClient&) override { return false; }

+ bool hasThumb(const ScrollbarThemeClient&) override { return true; }

- IntRect backButtonRect(const ScrollbarThemeClient*, ScrollbarPart, bool /*painting*/ = false) override { return IntRect(); }

- IntRect forwardButtonRect(const ScrollbarThemeClient*, ScrollbarPart, bool /*painting*/ = false) override { return IntRect(); }

- IntRect trackRect(const ScrollbarThemeClient*, bool painting = false) override;

+ IntRect backButtonRect(const ScrollbarThemeClient&, ScrollbarPart, bool /*painting*/ = false) override { return IntRect(); }

+ IntRect forwardButtonRect(const ScrollbarThemeClient&, ScrollbarPart, bool /*painting*/ = false) override { return IntRect(); }

+ IntRect trackRect(const ScrollbarThemeClient&, bool painting = false) override;

- void paintTrackBackground(GraphicsContext*, const ScrollbarThemeClient*, const IntRect&) override;

- void paintThumb(GraphicsContext*, const ScrollbarThemeClient*, const IntRect&) override;

+ void paintTrackBackground(GraphicsContext&, const ScrollbarThemeClient&, const IntRect&) override;

+ void paintThumb(GraphicsContext&, const ScrollbarThemeClient&, const IntRect&) override;

private:

bool isMockTheme() const final { return true; }