Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.h

Issue 1511003003: Use refs for non-null GraphicsContext, Scrollbar, etc. in scrollbar related code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ScrollbarRemove
Patch Set: yet another mac fix Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.h
diff --git a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.h b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.h
index d74d8403783eafd1a0ccee4a43c091da4746d112..d4c62a6fb438b9dfa7cb73db06507e035c7831bf 100644
--- a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.h
+++ b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.h
@@ -40,32 +40,32 @@ namespace blink {
class PLATFORM_EXPORT ScrollbarThemeMacOverlayAPI : public ScrollbarThemeMacCommon {
public:
bool shouldRepaintAllPartsOnInvalidation() const override { return false; }
- void updateEnabledState(const ScrollbarThemeClient*) override;
+ void updateEnabledState(const ScrollbarThemeClient&) override;
int scrollbarThickness(ScrollbarControlSize = RegularScrollbar) override;
bool usesOverlayScrollbars() const override;
- void updateScrollbarOverlayStyle(const ScrollbarThemeClient*) override;
+ void updateScrollbarOverlayStyle(const ScrollbarThemeClient&) override;
ScrollbarButtonsPlacement buttonsPlacement() const override;
- void registerScrollbar(ScrollbarThemeClient*) override;
- void unregisterScrollbar(ScrollbarThemeClient*) override;
+ void registerScrollbar(ScrollbarThemeClient&) override;
+ void unregisterScrollbar(ScrollbarThemeClient&) override;
- void setNewPainterForScrollbar(ScrollbarThemeClient*, ScrollbarPainter);
- ScrollbarPainter painterForScrollbar(const ScrollbarThemeClient*) const;
+ void setNewPainterForScrollbar(ScrollbarThemeClient&, ScrollbarPainter);
+ ScrollbarPainter painterForScrollbar(const ScrollbarThemeClient&) const;
- void paintTrackBackground(GraphicsContext*, const ScrollbarThemeClient*, const IntRect&) override;
- void paintThumb(GraphicsContext*, const ScrollbarThemeClient*, const IntRect&) override;
+ void paintTrackBackground(GraphicsContext&, const ScrollbarThemeClient&, const IntRect&) override;
+ void paintThumb(GraphicsContext&, const ScrollbarThemeClient&, const IntRect&) override;
- float thumbOpacity(const ScrollbarThemeClient*) const override;
+ float thumbOpacity(const ScrollbarThemeClient&) const override;
protected:
- IntRect trackRect(const ScrollbarThemeClient*, bool painting = false) override;
- IntRect backButtonRect(const ScrollbarThemeClient*, ScrollbarPart, bool painting = false) override;
- IntRect forwardButtonRect(const ScrollbarThemeClient*, ScrollbarPart, bool painting = false) override;
+ IntRect trackRect(const ScrollbarThemeClient&, bool painting = false) override;
+ IntRect backButtonRect(const ScrollbarThemeClient&, ScrollbarPart, bool painting = false) override;
+ IntRect forwardButtonRect(const ScrollbarThemeClient&, ScrollbarPart, bool painting = false) override;
- bool hasButtons(const ScrollbarThemeClient*) override { return false; }
- bool hasThumb(const ScrollbarThemeClient*) override;
+ bool hasButtons(const ScrollbarThemeClient&) override { return false; }
+ bool hasThumb(const ScrollbarThemeClient&) override;
- int minimumThumbLength(const ScrollbarThemeClient*) override;
+ int minimumThumbLength(const ScrollbarThemeClient&) override;
};
}

Powered by Google App Engine
This is Rietveld 408576698