third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h - Issue 1511003003: Use refs for non-null GraphicsContext, Scrollbar, etc. in scrollbar related code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h

Issue 1511003003: Use refs for non-null GraphicsContext, Scrollbar, etc. in scrollbar related code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ScrollbarRemove

Patch Set: yet another mac fix Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacCommon.mm ('k') | third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h

index 42547296591a396fdc0696c26c9dcb6d5dd980c6..15d287c2947cad543f8dcdc5f1a39eec4c95a665 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h

+++ b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h

@@ -43,20 +43,20 @@ public:

bool usesOverlayScrollbars() const override { return false; }

ScrollbarButtonsPlacement buttonsPlacement() const override;

- bool paint(const ScrollbarThemeClient*, GraphicsContext*, const CullRect&) override;

+ bool paint(const ScrollbarThemeClient&, GraphicsContext&, const CullRect&) override;

bool invalidateOnWindowActiveChange() const override { return true; }

protected:

- IntRect trackRect(const ScrollbarThemeClient*, bool painting = false) override;

- IntRect backButtonRect(const ScrollbarThemeClient*, ScrollbarPart, bool painting = false) override;

- IntRect forwardButtonRect(const ScrollbarThemeClient*, ScrollbarPart, bool painting = false) override;

+ IntRect trackRect(const ScrollbarThemeClient&, bool painting = false) override;

+ IntRect backButtonRect(const ScrollbarThemeClient&, ScrollbarPart, bool painting = false) override;

+ IntRect forwardButtonRect(const ScrollbarThemeClient&, ScrollbarPart, bool painting = false) override;

void updateButtonPlacement(ScrollbarButtonsPlacement) override;

- bool hasButtons(const ScrollbarThemeClient*) override;

- bool hasThumb(const ScrollbarThemeClient*) override;

+ bool hasButtons(const ScrollbarThemeClient&) override;

+ bool hasThumb(const ScrollbarThemeClient&) override;

- int minimumThumbLength(const ScrollbarThemeClient*) override;

+ int minimumThumbLength(const ScrollbarThemeClient&) override;

};

}