third_party/WebKit/Source/platform/scroll/Scrollbar.h - Issue 1511003003: Use refs for non-null GraphicsContext, Scrollbar, etc. in scrollbar related code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/Scrollbar.h

Issue 1511003003: Use refs for non-null GraphicsContext, Scrollbar, etc. in scrollbar related code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ScrollbarRemove

Patch Set: yet another mac fix Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp ('k') | third_party/WebKit/Source/platform/scroll/Scrollbar.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/Scrollbar.h

diff --git a/third_party/WebKit/Source/platform/scroll/Scrollbar.h b/third_party/WebKit/Source/platform/scroll/Scrollbar.h

index e8f806db5ebb1f69f92d32a9ecc61a4ca020454e..3d47eb6033eab3ac34096406c7aafe4b011a56e9 100644

--- a/third_party/WebKit/Source/platform/scroll/Scrollbar.h

+++ b/third_party/WebKit/Source/platform/scroll/Scrollbar.h

@@ -104,7 +104,7 @@ public:

void setProportion(int visibleSize, int totalSize);

void setPressedPos(int p) { m_pressedPos = p; }

- void paint(GraphicsContext*, const CullRect&) const final;

+ void paint(GraphicsContext&, const CullRect&) const final;

bool isOverlayScrollbar() const override;

bool shouldParticipateInHitTesting();

@@ -125,7 +125,7 @@ public:

void mouseUp(const PlatformMouseEvent&);

void mouseDown(const PlatformMouseEvent&);

- ScrollbarTheme* theme() const { return m_theme; }

+ ScrollbarTheme& theme() const { return m_theme; }

IntRect convertToContainingWidget(const IntRect&) const override;

IntRect convertFromContainingWidget(const IntRect&) const override;

@@ -177,7 +177,7 @@ protected:

RawPtrWillBeMember<ScrollableArea> m_scrollableArea;

ScrollbarOrientation m_orientation;

ScrollbarControlSize m_controlSize;

- ScrollbarTheme* m_theme;

+ ScrollbarTheme& m_theme;

int m_visibleSize;

int m_totalSize;