third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h - Issue 1511003003: Use refs for non-null GraphicsContext, Scrollbar, etc. in scrollbar related code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h

Issue 1511003003: Use refs for non-null GraphicsContext, Scrollbar, etc. in scrollbar related code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ScrollbarRemove

Patch Set: yet another mac fix Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm ('k') | third_party/WebKit/Source/platform/scroll/ScrollableArea.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h

index 0a5618317dc214bb05a9b32feac2fa34f181e0a5..49b51eb452cd6a5de037288af65c6f48fc143af7 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h

@@ -80,8 +80,8 @@ public:

virtual void mouseEnteredContentArea() const { }

virtual void mouseExitedContentArea() const { }

virtual void mouseMovedInContentArea() const { }

- virtual void mouseEnteredScrollbar(Scrollbar*) const { }

- virtual void mouseExitedScrollbar(Scrollbar*) const { }

+ virtual void mouseEnteredScrollbar(Scrollbar&) const { }

+ virtual void mouseExitedScrollbar(Scrollbar&) const { }

virtual void willStartLiveResize() { }

virtual void updateAfterLayout() { }

virtual void contentsResized() const { }

@@ -91,12 +91,12 @@ public:

virtual void finishCurrentScrollAnimations() { }

- virtual void didAddVerticalScrollbar(Scrollbar*) { }

- virtual void willRemoveVerticalScrollbar(Scrollbar*) { }

- virtual void didAddHorizontalScrollbar(Scrollbar*) { }

- virtual void willRemoveHorizontalScrollbar(Scrollbar*) { }

+ virtual void didAddVerticalScrollbar(Scrollbar&) { }

+ virtual void willRemoveVerticalScrollbar(Scrollbar&) { }

+ virtual void didAddHorizontalScrollbar(Scrollbar&) { }

+ virtual void willRemoveHorizontalScrollbar(Scrollbar&) { }

- virtual bool shouldScrollbarParticipateInHitTesting(Scrollbar*) { return true; }

+ virtual bool shouldScrollbarParticipateInHitTesting(Scrollbar&) { return true; }

virtual void notifyContentAreaScrolled(const FloatSize&) { }