third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h - Issue 1511003003: Use refs for non-null GraphicsContext, Scrollbar, etc. in scrollbar related code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Issue 1511003003: Use refs for non-null GraphicsContext, Scrollbar, etc. in scrollbar related code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ScrollbarRemove

Patch Set: yet another mac fix Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

index 46ace1f5842f14e78e52e2089184b8bb27c6ff43..bb1973e992d0cc72c17d57facb325f287b41ec09 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

@@ -193,10 +193,10 @@ public:

bool isActive() const override;

bool isScrollCornerVisible() const override;

IntRect scrollCornerRect() const override;

- IntRect convertFromScrollbarToContainingWidget(const Scrollbar*, const IntRect&) const override;

- IntRect convertFromContainingWidgetToScrollbar(const Scrollbar*, const IntRect&) const override;

- IntPoint convertFromScrollbarToContainingWidget(const Scrollbar*, const IntPoint&) const override;

- IntPoint convertFromContainingWidgetToScrollbar(const Scrollbar*, const IntPoint&) const override;

+ IntRect convertFromScrollbarToContainingWidget(const Scrollbar&, const IntRect&) const override;

+ IntRect convertFromContainingWidgetToScrollbar(const Scrollbar&, const IntRect&) const override;

+ IntPoint convertFromScrollbarToContainingWidget(const Scrollbar&, const IntPoint&) const override;

+ IntPoint convertFromContainingWidgetToScrollbar(const Scrollbar&, const IntPoint&) const override;

int scrollSize(ScrollbarOrientation) const override;

IntPoint scrollPosition() const override;

DoublePoint scrollPositionDouble() const override;

@@ -348,7 +348,7 @@ private:

LayoutUnit verticalScrollbarStart(int minX, int maxX) const;

LayoutUnit horizontalScrollbarStart(int minX) const;

- IntSize scrollbarOffset(const Scrollbar*) const;

+ IntSize scrollbarOffset(const Scrollbar&) const;

void setHasHorizontalScrollbar(bool hasScrollbar);

void setHasVerticalScrollbar(bool hasScrollbar);