[Chromecast] Set dummy metrics session ID for browser tests

[Chromecast] Set dummy metrics session ID for browser tests

This reverts https://codereview.chromium.org/1477483003/ which was
intended to fix a problem where media playback in browser tests
triggers metrics events that DCHECK on invalid session ID.

Previous attempt set a dummy session ID, but this could mask bugs
if we ever failed to set session ID correctly.  Instead, explicitly
only set the dummy ID for running browser tests.

BUG=

Committed: https://crrev.com/7296007481dc9216de5a868451cde453b22cb00b
Cr-Commit-Position: refs/heads/master@{#376099}

[halliwell, 2015-12-10 23:12:12]

The CQ bit was checked by halliwell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-10 23:13:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1510973007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1510973007/1

[commit-bot: I haz the power, 2015-12-10 23:38:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 23:38:10]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[halliwell, 2015-12-10 23:49:39]

The CQ bit was checked by halliwell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-10 23:51:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1510973007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1510973007/20001

[commit-bot: I haz the power, 2015-12-11 00:36:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-11 00:36:11]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[halliwell, 2015-12-11 00:43:34]

The CQ bit was checked by halliwell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-11 00:44:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1510973007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1510973007/40001

[commit-bot: I haz the power, 2015-12-11 01:06:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-11 01:06:01]

Dry run: This issue passed the CQ dry run.

[halliwell, 2015-12-11 01:08:15]

Description was changed from

==========
[Chromecast] Set dummy metrics session ID for browser tests

This reverts https://codereview.chromium.org/1477483003/ which was
intended to fix a problem where media playback in browser tests
triggers metrics events that DCHECK on invalid session ID.

Previous attempt set a dummy session ID, but this could mask bugs
if we ever failed to set session ID correctly.  Instead, explicitly
only set the dummy ID for running browser tests.

BUG=
==========

to

==========
[Chromecast] Set dummy metrics session ID for browser tests

This reverts https://codereview.chromium.org/1477483003/ which was
intended to fix a problem where media playback in browser tests
triggers metrics events that DCHECK on invalid session ID.

Previous attempt set a dummy session ID, but this could mask bugs
if we ever failed to set session ID correctly.  Instead, explicitly
only set the dummy ID for running browser tests.

BUG=
==========

[halliwell, 2015-12-11 01:08:15]

halliwell@chromium.org changed reviewers:
+ gfhuang@chromium.org, mbjorge@chromium.org

[halliwell, 2016-02-13 00:29:15]

Woah just found this in my chromium code review dashboard.  2 months old!  PTAL
:)

[mbjorge, 2016-02-13 00:30:41]

lgtm

[gfhuang, 2016-02-13 00:33:46]

lgtm, one nit.

[gfhuang, 2016-02-13 00:34:02]

lgtm, 1 nit.

https://codereview.chromium.org/1510973007/diff/40001/chromecast/base/metrics...
File chromecast/base/metrics/cast_metrics_helper.cc (right):

https://codereview.chromium.org/1510973007/diff/40001/chromecast/base/metrics...
chromecast/base/metrics/cast_metrics_helper.cc:231: session_id_ =
"00000000000000000000000000000000";
use GUID format

"00000000-0000-0000-0000-000000000000"

[halliwell, 2016-02-18 04:36:11]

On 2016/02/13 00:34:02, gfhuang wrote:
> lgtm, 1 nit.
> 
>
https://codereview.chromium.org/1510973007/diff/40001/chromecast/base/metrics...
> File chromecast/base/metrics/cast_metrics_helper.cc (right):
> 
>
https://codereview.chromium.org/1510973007/diff/40001/chromecast/base/metrics...
> chromecast/base/metrics/cast_metrics_helper.cc:231: session_id_ =
> "00000000000000000000000000000000";
> use GUID format
> 
> "00000000-0000-0000-0000-000000000000"

done.

[halliwell, 2016-02-18 04:36:37]

The CQ bit was checked by halliwell@chromium.org

[halliwell, 2016-02-18 04:36:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
gfhuang@chromium.org, mbjorge@chromium.org
Link to the patchset: https://codereview.chromium.org/1510973007/#ps60001
(title: "Rebase + use GUID format for dummy session ID")

[commit-bot: I haz the power, 2016-02-18 04:37:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1510973007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1510973007/60001

[commit-bot: I haz the power, 2016-02-18 05:19:16]

Description was changed from

==========
[Chromecast] Set dummy metrics session ID for browser tests

This reverts https://codereview.chromium.org/1477483003/ which was
intended to fix a problem where media playback in browser tests
triggers metrics events that DCHECK on invalid session ID.

Previous attempt set a dummy session ID, but this could mask bugs
if we ever failed to set session ID correctly.  Instead, explicitly
only set the dummy ID for running browser tests.

BUG=
==========

to

==========
[Chromecast] Set dummy metrics session ID for browser tests

This reverts https://codereview.chromium.org/1477483003/ which was
intended to fix a problem where media playback in browser tests
triggers metrics events that DCHECK on invalid session ID.

Previous attempt set a dummy session ID, but this could mask bugs
if we ever failed to set session ID correctly.  Instead, explicitly
only set the dummy ID for running browser tests.

BUG=
==========

[commit-bot: I haz the power, 2016-02-18 05:19:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-18 05:20:23]

Description was changed from

==========
[Chromecast] Set dummy metrics session ID for browser tests

This reverts https://codereview.chromium.org/1477483003/ which was
intended to fix a problem where media playback in browser tests
triggers metrics events that DCHECK on invalid session ID.

Previous attempt set a dummy session ID, but this could mask bugs
if we ever failed to set session ID correctly.  Instead, explicitly
only set the dummy ID for running browser tests.

BUG=
==========

to

==========
[Chromecast] Set dummy metrics session ID for browser tests

This reverts https://codereview.chromium.org/1477483003/ which was
intended to fix a problem where media playback in browser tests
triggers metrics events that DCHECK on invalid session ID.

Previous attempt set a dummy session ID, but this could mask bugs
if we ever failed to set session ID correctly.  Instead, explicitly
only set the dummy ID for running browser tests.

BUG=

Committed: https://crrev.com/7296007481dc9216de5a868451cde453b22cb00b
Cr-Commit-Position: refs/heads/master@{#376099}
==========

[commit-bot: I haz the power, 2016-02-18 05:20:24]

Patchset 4 (id:??) landed as
https://crrev.com/7296007481dc9216de5a868451cde453b22cb00b
Cr-Commit-Position: refs/heads/master@{#376099}