Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: third_party/WebKit/LayoutTests/fast/css/variables/read-from-computed-style.html

Issue 1510963002: Ensure we don't crash when asking for variables that don't exist from the computed style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dammit tim Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/css/variables/read-from-computed-style.html
diff --git a/third_party/WebKit/LayoutTests/fast/css/variables/read-from-computed-style.html b/third_party/WebKit/LayoutTests/fast/css/variables/read-from-computed-style.html
index f0d2ea26687fa165db197fe818ab3b4754aeb375..730033be50dfea462d9a0f4d73391e3845a5fb54 100644
--- a/third_party/WebKit/LayoutTests/fast/css/variables/read-from-computed-style.html
+++ b/third_party/WebKit/LayoutTests/fast/css/variables/read-from-computed-style.html
@@ -23,23 +23,27 @@ test(function() {
assert_equals(getComputedStyle(container).getPropertyValue("--a"), " it was the best of times");
assert_equals(getComputedStyle(container).getPropertyValue("--b"), " it was the worst of times");
assert_equals(getComputedStyle(container).getPropertyValue("--c"), " also the blurst of times");
+ assert_equals(getComputedStyle(container).getPropertyValue("--d"), "");
}, 'Directly declared custom properties appear in computed style.');
test(function() {
assert_equals(getComputedStyle(a).getPropertyValue("--a"), " it was the best of times");
assert_equals(getComputedStyle(a).getPropertyValue("--b"), " it was the worst of times");
assert_equals(getComputedStyle(a).getPropertyValue("--c"), " also the blurst of times");
+ assert_equals(getComputedStyle(a).getPropertyValue("--d"), "");
}, 'Inherited custom properties appear in computed style.');
test(function() {
assert_equals(getComputedStyle(b).getPropertyValue("--a"), " it was the best of times");
assert_equals(getComputedStyle(b).getPropertyValue("--b"), " it was the worst of times");
assert_equals(getComputedStyle(b).getPropertyValue("--c"), " it was the age of wisdom");
+ assert_equals(getComputedStyle(b).getPropertyValue("--d"), "");
}, 'Inherited custom properties overidden values appear correctly in computed style.');
test(function() {
assert_equals(getComputedStyle(c).getPropertyValue("--a"), " it was the best of times");
assert_equals(getComputedStyle(c).getPropertyValue("--b"), " it was the worst of times");
assert_equals(getComputedStyle(c).getPropertyValue("--c"), " it was the age of wisdom");
+ assert_equals(getComputedStyle(c).getPropertyValue("--d"), "");
}, 'Overidden and inherited custom properties appear in computed style.');
</script>
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698