Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1510963002: Ensure we don't crash when asking for variables that don't exist from the computed style. (Closed)

Created:
5 years ago by shans
Modified:
5 years ago
Reviewers:
dstockwell, Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure we don't crash when asking for variables that don't exist from the computed style. BUG=465126 Committed: https://crrev.com/5f9d34ee27d83c1eff117adfa5c1e92142c0f50c Cr-Commit-Position: refs/heads/master@{#364650}

Patch Set 1 #

Total comments: 3

Patch Set 2 : dammit tim #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/variables/read-from-computed-style.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
dstockwell
lgtm https://codereview.chromium.org/1510963002/diff/1/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp File third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp (right): https://codereview.chromium.org/1510963002/diff/1/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp#newcode646 third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp:646: if (value) indentation
5 years ago (2015-12-08 21:32:39 UTC) #2
shans
https://codereview.chromium.org/1510963002/diff/1/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp File third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp (right): https://codereview.chromium.org/1510963002/diff/1/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp#newcode646 third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp:646: if (value) On 2015/12/08 at 21:32:39, dstockwell wrote: > ...
5 years ago (2015-12-08 21:49:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510963002/1
5 years ago (2015-12-08 21:51:28 UTC) #5
Timothy Loh
lgtm https://codereview.chromium.org/1510963002/diff/1/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp File third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp (right): https://codereview.chromium.org/1510963002/diff/1/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp#newcode1363 third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp:1363: return CSSCustomPropertyDeclaration::create(customPropertyName, style.variables()->getVariable(customPropertyName)); Since you already looked it ...
5 years ago (2015-12-08 23:53:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510963002/20001
5 years ago (2015-12-11 05:11:57 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-11 09:04:01 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-11 09:04:45 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f9d34ee27d83c1eff117adfa5c1e92142c0f50c
Cr-Commit-Position: refs/heads/master@{#364650}

Powered by Google App Engine
This is Rietveld 408576698