Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(69)

Issue 151095: Added unit tests for ClearBrowsingDataController.... (Closed)

Created:
9 years, 10 months ago by Jens
Modified:
8 years ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)
Visibility:
Public.

Description

Added unit tests for ClearBrowsingDataController. Fixed a bug in ClearBrowsingDataController: checking Delete Form Data would end up deleting passwords instead. BUG=12902 TEST=true

Patch Set 1 #

Total comments: 11

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -13 lines) Patch
M chrome/browser/cocoa/clear_browsing_data_controller.h View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/cocoa/clear_browsing_data_controller.mm View 1 2 chunks +15 lines, -12 lines 0 comments Download
A chrome/browser/cocoa/clear_browsing_data_controller_unittest.mm View 1 2 1 chunk +110 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Jens
9 years, 10 months ago (2009-06-30 18:46:33 UTC) #1
pink (ping after 24hrs)
This is AWESOME! A couple of nits to fix: http://codereview.chromium.org/151095/diff/1/3 File chrome/browser/cocoa/clear_browsing_data_controller.mm (right): http://codereview.chromium.org/151095/diff/1/3#newcode113 Line ...
9 years, 10 months ago (2009-06-30 18:51:08 UTC) #2
Jens
http://codereview.chromium.org/151095/diff/1/3 File chrome/browser/cocoa/clear_browsing_data_controller.mm (right): http://codereview.chromium.org/151095/diff/1/3#newcode113 Line 113: remover_->Remove(self.removeMask); On 2009/06/30 18:51:08, pink wrote: > [self ...
9 years, 10 months ago (2009-06-30 22:52:07 UTC) #3
pink (ping after 24hrs)
LGTM. i'll try to get this landed today, but poke me if i haven't gotten ...
9 years, 10 months ago (2009-07-01 12:41:20 UTC) #4
pink (ping after 24hrs)
9 years, 10 months ago (2009-07-01 14:41:02 UTC) #5
landed.

Powered by Google App Engine
This is Rietveld 408576698