Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1510943005: Remove a couple of unnecessary lines from test status files. (Closed)

Created:
5 years ago by Kevin Millikin (Google)
Modified:
5 years ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove a couple of unnecessary lines from test status files. The test runner will generate a filename from the test name in the status file. If the status file contains a filename, it does not match any test. R=whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ff12f5ddd0994b08ff9b544b1c853669ff395ace

Patch Set 1 #

Patch Set 2 : Incorporate review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/co19/co19-dart2js.status View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dartium.status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Kevin Millikin (Google)
5 years ago (2015-12-10 12:09:44 UTC) #1
Bill Hesse
I would rather have those lines fixed, and remain in the status file. Those tests ...
5 years ago (2015-12-10 12:33:08 UTC) #2
Kevin Millikin (Google)
Take another look. QED.
5 years ago (2015-12-10 13:44:09 UTC) #3
Bill Hesse
lgtm
5 years ago (2015-12-10 14:01:07 UTC) #4
Kevin Millikin (Google)
5 years ago (2015-12-11 13:20:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ff12f5ddd0994b08ff9b544b1c853669ff395ace (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698