Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 151093005: cc: Update Main RendererCapabilities on DeferredInitialize (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Release Mailbox if UsingSharedMemoryResources changed in TextureLayer::Update Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index ec89ddcfd734a055a9cdc9fa4dd9bc60bc870f99..7339ea27ba5dcf93de505bf0090e22b901e4f977 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -1875,6 +1875,7 @@ bool LayerTreeHostImpl::DeferredInitialize(
if (success) {
EnforceZeroBudget(false);
+ client_->UpdateRendererCapabilitiesOnImplThread();
enne (OOO) 2014/02/14 20:21:48 This seems like the wrong place to do this. Can y
boliu 2014/02/14 22:03:08 UpdateRendererCapabilitiesOnImplThread is only use
enne (OOO) 2014/02/14 22:08:49 Can there be only one?
boliu 2014/02/14 22:14:49 No...webview has the crazy requirement to synchron
enne (OOO) 2014/02/14 22:19:39 Sure, but the caps can still be sent back the same
boliu 2014/02/14 22:27:30 So InitializeRenderer has main thread blocked and
enne (OOO) 2014/02/14 23:02:27 Maybe it's just me, but I would rather have Create
client_->SetNeedsCommitOnImplThread();
} else {
if (offscreen_context_provider.get()) {
@@ -1928,6 +1929,7 @@ void LayerTreeHostImpl::ReleaseGL() {
SetOffscreenContextProvider(NULL);
+ client_->UpdateRendererCapabilitiesOnImplThread();
client_->SetNeedsCommitOnImplThread();
}

Powered by Google App Engine
This is Rietveld 408576698