Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4160)

Unified Diff: cc/trees/single_thread_proxy.cc

Issue 151093005: cc: Update Main RendererCapabilities on DeferredInitialize (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: with tests Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/single_thread_proxy.cc
diff --git a/cc/trees/single_thread_proxy.cc b/cc/trees/single_thread_proxy.cc
index dcd4cf679b74500ee3ad7fa901d675f6700de710..ba3f2b954fb81302d970552ac04813251bb01d8e 100644
--- a/cc/trees/single_thread_proxy.cc
+++ b/cc/trees/single_thread_proxy.cc
@@ -147,11 +147,7 @@ void SingleThreadProxy::CreateAndInitializeOutputSurface() {
DCHECK(output_surface);
initialized = layer_tree_host_impl_->InitializeRenderer(
output_surface.Pass());
- if (initialized) {
- renderer_capabilities_for_main_thread_ =
- layer_tree_host_impl_->GetRendererCapabilities()
- .MainThreadCapabilities();
- } else if (offscreen_context_provider.get()) {
+ if (!initialized && offscreen_context_provider.get()) {
offscreen_context_provider->VerifyContexts();
offscreen_context_provider = NULL;
}
@@ -166,6 +162,10 @@ void SingleThreadProxy::CreateAndInitializeOutputSurface() {
void SingleThreadProxy::OnOutputSurfaceInitializeAttempted(bool success) {
LayerTreeHost::CreateResult result =
layer_tree_host_->OnCreateAndInitializeOutputSurfaceAttempted(success);
+ if (success) {
+ UpdateRendererCapabilitiesOnImplThread();
+ }
+
if (result == LayerTreeHost::CreateFailedButTryAgain) {
// Force another recreation attempt to happen by requesting another commit.
SetNeedsCommit();
@@ -370,6 +370,12 @@ void SingleThreadProxy::SendManagedMemoryStats() {
bool SingleThreadProxy::IsInsideDraw() { return inside_draw_; }
+void SingleThreadProxy::UpdateRendererCapabilitiesOnImplThread() {
+ renderer_capabilities_for_main_thread_ =
+ layer_tree_host_impl_->GetRendererCapabilities().MainThreadCapabilities();
+ layer_tree_host_->RendererCapabilitiesChanged();
boliu 2014/02/07 04:29:55 This will never actually be called by LayerTreeHos
danakj 2014/02/11 19:58:59 I don't see how this won't be reached, it's called
+}
+
void SingleThreadProxy::DidLoseOutputSurfaceOnImplThread() {
TRACE_EVENT0("cc", "SingleThreadProxy::DidLoseOutputSurfaceOnImplThread");
// Cause a commit so we can notice the lost context.

Powered by Google App Engine
This is Rietveld 408576698