Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1510913005: [proxies] Fix "with" statements for proxies (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com, Camillo Bruni, Toon Verwaest
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Fix "with" statements for proxies BUG=v8:1543 LOG=n Committed: https://crrev.com/e2dd98a39e98363843aa6f9c73cdf25ce4a7072a Cr-Commit-Position: refs/heads/master@{#32756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M src/contexts.cc View 2 chunks +22 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
PTAL.
5 years ago (2015-12-10 13:14:05 UTC) #2
neis
lgtm
5 years ago (2015-12-10 14:22:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510913005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510913005/1
5 years ago (2015-12-10 14:30:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 15:12:06 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 15:12:49 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e2dd98a39e98363843aa6f9c73cdf25ce4a7072a
Cr-Commit-Position: refs/heads/master@{#32756}

Powered by Google App Engine
This is Rietveld 408576698