src/xml/SkDOM.cpp - Issue 1510903005: another null src, memcpy -> sk_careful_memcpy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/xml/SkDOM.cpp

Issue 1510903005: another null src, memcpy -> sk_careful_memcpy (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/xml/SkDOM.cpp

diff --git a/src/xml/SkDOM.cpp b/src/xml/SkDOM.cpp

index 68e2938d9a347b115ead05640cb2a076c50922c0..0f0b614f1116bed80ccf7cf5f4a1e6f9d9d43d34 100644

--- a/src/xml/SkDOM.cpp

+++ b/src/xml/SkDOM.cpp

@@ -240,7 +240,7 @@ protected:

}

*fParentStack.push() = node;

- memcpy(node->attrs(), fAttrs.begin(), attrCount * sizeof(SkDOM::Attr));

+ sk_careful_memcpy(node->attrs(), fAttrs.begin(), attrCount * sizeof(SkDOM::Attr));

fAttrs.reset();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »