Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1510903002: Stop wrapping images backed by generators as bitmaps in SkGpuDevice (except when tiling) (Closed)

Created:
5 years ago by bsalomon
Modified:
5 years ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Stop wrapping images backed by generators as bitmaps in SkGpuDevice (except when tiling) Committed: https://skia.googlesource.com/skia/+/1cf6f9b6b51bcf09d93142ba40d6c331c21f50a6

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -76 lines) Patch
M src/core/SkImageCacherator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkImageCacherator.cpp View 2 chunks +2 lines, -48 lines 0 comments Download
M src/gpu/GrImageIDTextureAdjuster.h View 1 2 2 chunks +27 lines, -0 lines 0 comments Download
M src/gpu/GrImageIDTextureAdjuster.cpp View 1 2 chunks +31 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 3 chunks +36 lines, -27 lines 0 comments Download
M src/image/SkImage_Base.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/image/SkImage_Generator.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1504723004 Patch 1
Issue 1504723004 Patch 20001

Messages

Total messages: 8 (3 generated)
bsalomon
5 years ago (2015-12-08 15:52:19 UTC) #2
robertphillips
lgtm
5 years ago (2015-12-08 16:25:03 UTC) #3
reed1
woot! lgtm
5 years ago (2015-12-08 17:05:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510903002/40001
5 years ago (2015-12-08 18:19:29 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-08 18:53:46 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/1cf6f9b6b51bcf09d93142ba40d6c331c21f50a6

Powered by Google App Engine
This is Rietveld 408576698