Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gyp/common_conditions.gypi

Issue 1510843003: Add RTTI to all sanitizers. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: remove tab Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common_conditions.gypi
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi
index 7a03f64a7ecf09d9886e7519ff0c5cc7cb814117..f7138aa6119dfaf0863923c2057c6a23029a27f3 100644
--- a/gyp/common_conditions.gypi
+++ b/gyp/common_conditions.gypi
@@ -438,6 +438,9 @@
'-fsanitize=<(skia_sanitizer)',
'-fno-sanitize-recover=<(skia_sanitizer)',
],
+ 'cflags_cc!': [
+ '-fno-rtti'
+ ],
'ldflags': [
'-fsanitize=<(skia_sanitizer)',
],
@@ -445,9 +448,6 @@
[ 'skia_sanitizer == "thread"', {
'defines': [ 'THREAD_SANITIZER' ],
}],
- [ 'skia_sanitizer == "undefined"', {
- 'cflags_cc!': ['-fno-rtti'],
- }],
],
}],
[ 'skia_clang_build', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698