Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1510833003: Improve the CallSite constructor (Closed)

Created:
5 years ago by Toon Verwaest
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Improve the CallSite constructor BUG= Committed: https://crrev.com/897fecd58c9ec2cebff0d9f0d908438fc3aefdf0 Cr-Commit-Position: refs/heads/master@{#32722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -7 lines) Patch
M src/js/messages.js View 1 chunk +10 lines, -2 lines 0 comments Download
M src/messages.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/messages.cc View 1 chunk +3 lines, -4 lines 0 comments Download
A test/mjsunit/callsite.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
5 years ago (2015-12-08 16:30:26 UTC) #2
Yang
On 2015/12/08 16:30:26, Toon Verwaest wrote: > ptal lgtm.
5 years ago (2015-12-08 19:00:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510833003/1
5 years ago (2015-12-09 17:05:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 17:28:25 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-09 17:28:40 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/897fecd58c9ec2cebff0d9f0d908438fc3aefdf0
Cr-Commit-Position: refs/heads/master@{#32722}

Powered by Google App Engine
This is Rietveld 408576698