Fix #19137: handle when regexp doesn't match in constructorNameFallback

Fix #19137: handle when regexp doesn't match in constructorNameFallback

R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/db4195c75265c9e364cb3165864c62f55d1742a0

[Siggi Cherem (dart-lang), 2015-12-10 03:03:57]

sigmund@google.com changed reviewers:
+ sra@google.com

[Siggi Cherem (dart-lang), 2015-12-10 03:03:58]

I have not been able to test this in Safari 7 as the issue indicates that's
where they've seen the issue, but it seemed like a good idea to protect against
a null-match anyways.

[sra1, 2015-12-10 05:30:38]

lgtm

https://codereview.chromium.org/1510763006/diff/1/tests/html/websocket_test.dart
File tests/html/websocket_test.dart (right):

https://codereview.chromium.org/1510763006/diff/1/tests/html/websocket_test.d...
tests/html/websocket_test.dart:43: // The server supports ws, but not wss, this
will yeild an error that we
yield

https://codereview.chromium.org/1510763006/diff/1/tests/html/websocket_test.d...
tests/html/websocket_test.dart:51: // constructor.
I'm not clear how this fails / passes. Can you explain?

[Siggi Cherem (dart-lang), 2015-12-10 20:27:39]

https://codereview.chromium.org/1510763006/diff/1/tests/html/websocket_test.dart
File tests/html/websocket_test.dart (right):

https://codereview.chromium.org/1510763006/diff/1/tests/html/websocket_test.d...
tests/html/websocket_test.dart:43: // The server supports ws, but not wss, this
will yeild an error that we
On 2015/12/10 05:30:38, sra1 wrote:
> yield

Done.

https://codereview.chromium.org/1510763006/diff/1/tests/html/websocket_test.d...
tests/html/websocket_test.dart:51: // constructor.
On 2015/12/10 05:30:38, sra1 wrote:
> I'm not clear how this fails / passes. Can you explain?

Done - added more details.

I was not able to verify that this problem occurs, but I was able to reach the
enclosing function in FF, and by stepping through it and changing the result of
some conditions, I was able to validate that the erroneous code path could be
exercised.

[Siggi Cherem (dart-lang), 2015-12-10 20:28:16]

Description was changed from

==========
Fix #19137: handle when regexp doesn't match in constructorNameFallback
==========

to

==========
Fix #19137: handle when regexp doesn't match in constructorNameFallback

R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/db4195c75265c9e364cb3165864c62f55d1742a0
==========

[Siggi Cherem (dart-lang), 2015-12-10 20:28:17]

Committed patchset #2 (id:20001) manually as
db4195c75265c9e364cb3165864c62f55d1742a0 (presubmit successful).