Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1510763002: More differentiation in multiselect mode (Closed)

Created:
5 years ago by Peter Kasting
Modified:
5 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More differentiation in multiselect mode. * Make inactive selected tabs more distinct from the active tab by dropping the "active tab overlay alpha" from 45% to 30%. * Make unselected tabs more distinct from both by dropping their alpha from 75% to 60%. BUG=none TEST=none Committed: https://crrev.com/2391fd6a128c63f338363d36d1921a9bcca7dde4 Cr-Commit-Position: refs/heads/master@{#363871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/views/tabs/tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Peter Kasting
5 years ago (2015-12-08 04:45:30 UTC) #3
sky
Glen liked the values at the time. But I'm all for trying something more prominent. ...
5 years ago (2015-12-08 14:26:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510763002/1
5 years ago (2015-12-08 19:36:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 00:56:54 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-09 00:57:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2391fd6a128c63f338363d36d1921a9bcca7dde4
Cr-Commit-Position: refs/heads/master@{#363871}

Powered by Google App Engine
This is Rietveld 408576698