Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1510753004: Remove unused [RaisesException] for createNodeIterator() and createTreeWalker() (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused [RaisesException] for createNodeIterator() and createTreeWalker() While in the area, also assert that the root argument is not null, which is guaranteed since https://codereview.chromium.org/360463005 The FIXME is removed because the whatToShow default value is 0xFFFFFFFF, so any such warning would trigger by default. R=haraken@chromium.org Committed: https://crrev.com/94278580417ec6bbc7b1c99fead31b6cc448d9cb Cr-Commit-Position: refs/heads/master@{#363850}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
PTAL. No dry run because the tree is in bad shape right now, but it ...
5 years ago (2015-12-08 12:51:58 UTC) #1
haraken
LGTM
5 years ago (2015-12-08 13:45:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510753004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510753004/1
5 years ago (2015-12-08 22:43:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 00:31:09 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-09 00:31:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94278580417ec6bbc7b1c99fead31b6cc448d9cb
Cr-Commit-Position: refs/heads/master@{#363850}

Powered by Google App Engine
This is Rietveld 408576698