Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1510713002:
mash: Add a couple of apptests for AcceleratorRegistrar. (Closed)
|
Created:
5 years ago by sadrul Modified:
5 years ago Reviewers:
Ben Goodger (Google) CC:
chromium-reviews, kalyank, sadrul Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmash: Add a couple of apptests for AcceleratorRegistrar.
. Test that different AcceleratorRegistrars get different namespaces, and so can
install accelerators with the same id.
. Test that differentl registrars do not allow registering accelerators with the
same event matcher.
Previously landed in crrev.com/363719 with another test to make sure accelerators
are removed when a handler is destroyed. But that test is flaky, so it is removed.
BUG=548363, 568167
Committed: https://crrev.com/80eae475b9325581067a7b743965cc315adca177
Cr-Commit-Position: refs/heads/master@{#364739}
Patch Set 1 #Patch Set 2 : gn-check #Patch Set 3 : remove-failing-test #
Messages
Total messages: 22 (12 generated)
sadrul@chromium.org changed reviewers: + ben@chromium.org
Description was changed from ========== mash: Add a couple of apptests for AcceleratorRegistrar. . Test that different AcceleratorRegistrars get different namespaces, and so can install accelerators with the same id. . Test that differentl registrars do not allow registering accelerators with the same event matcher. . Test that destroying an AcceleratorHandler removes the associated accelerators. BUG=548363 ========== to ========== mash: Add a couple of apptests for AcceleratorRegistrar. . Test that different AcceleratorRegistrars get different namespaces, and so can install accelerators with the same id. . Test that differentl registrars do not allow registering accelerators with the same event matcher. . Test that destroying an AcceleratorHandler removes associated accelerators. BUG=548363 ==========
lgtm
The CQ bit was checked by sadrul@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org Link to the patchset: https://codereview.chromium.org/1510713002/#ps20001 (title: "gn-check")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510713002/20001
Message was sent while issue was closed.
Description was changed from ========== mash: Add a couple of apptests for AcceleratorRegistrar. . Test that different AcceleratorRegistrars get different namespaces, and so can install accelerators with the same id. . Test that differentl registrars do not allow registering accelerators with the same event matcher. . Test that destroying an AcceleratorHandler removes associated accelerators. BUG=548363 ========== to ========== mash: Add a couple of apptests for AcceleratorRegistrar. . Test that different AcceleratorRegistrars get different namespaces, and so can install accelerators with the same id. . Test that differentl registrars do not allow registering accelerators with the same event matcher. . Test that destroying an AcceleratorHandler removes associated accelerators. BUG=548363 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== mash: Add a couple of apptests for AcceleratorRegistrar. . Test that different AcceleratorRegistrars get different namespaces, and so can install accelerators with the same id. . Test that differentl registrars do not allow registering accelerators with the same event matcher. . Test that destroying an AcceleratorHandler removes associated accelerators. BUG=548363 ========== to ========== mash: Add a couple of apptests for AcceleratorRegistrar. . Test that different AcceleratorRegistrars get different namespaces, and so can install accelerators with the same id. . Test that differentl registrars do not allow registering accelerators with the same event matcher. . Test that destroying an AcceleratorHandler removes associated accelerators. BUG=548363 Committed: https://crrev.com/8aac81dc92c8eaaec476b0c6c5ccf3e114590b68 Cr-Commit-Position: refs/heads/master@{#363719} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8aac81dc92c8eaaec476b0c6c5ccf3e114590b68 Cr-Commit-Position: refs/heads/master@{#363719}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1516013002/ by mek@chromium.org. The reason for reverting is: AcceleratorRegistrarTest.AcceleratorsRemovedOnHandlerDestroy is flaky on both trybots and the main waterfall (see https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/35418 for one random example where it failed). BUG=568634.
Message was sent while issue was closed.
Description was changed from ========== mash: Add a couple of apptests for AcceleratorRegistrar. . Test that different AcceleratorRegistrars get different namespaces, and so can install accelerators with the same id. . Test that differentl registrars do not allow registering accelerators with the same event matcher. . Test that destroying an AcceleratorHandler removes associated accelerators. BUG=548363 Committed: https://crrev.com/8aac81dc92c8eaaec476b0c6c5ccf3e114590b68 Cr-Commit-Position: refs/heads/master@{#363719} ========== to ========== mash: Add a couple of apptests for AcceleratorRegistrar. . Test that different AcceleratorRegistrars get different namespaces, and so can install accelerators with the same id. . Test that differentl registrars do not allow registering accelerators with the same event matcher. . Test that destroying an AcceleratorHandler removes associated accelerators. BUG=548363 Committed: https://crrev.com/8aac81dc92c8eaaec476b0c6c5ccf3e114590b68 Cr-Commit-Position: refs/heads/master@{#363719} ==========
Description was changed from ========== mash: Add a couple of apptests for AcceleratorRegistrar. . Test that different AcceleratorRegistrars get different namespaces, and so can install accelerators with the same id. . Test that differentl registrars do not allow registering accelerators with the same event matcher. . Test that destroying an AcceleratorHandler removes associated accelerators. BUG=548363 Committed: https://crrev.com/8aac81dc92c8eaaec476b0c6c5ccf3e114590b68 Cr-Commit-Position: refs/heads/master@{#363719} ========== to ========== mash: Add a couple of apptests for AcceleratorRegistrar. . Test that different AcceleratorRegistrars get different namespaces, and so can install accelerators with the same id. . Test that differentl registrars do not allow registering accelerators with the same event matcher. Previously landed in crrev.com/363719 with another test to make sure accelerators are removed when a handler is destroyed. But that test is flaky, so it is removed. BUG=548363, 568167 ==========
I removed the failing app test from the CL. Re-landing the good test while I investigate a fix for the failing one.
The CQ bit was checked by sadrul@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org Link to the patchset: https://codereview.chromium.org/1510713002/#ps40001 (title: "remove-failing-test")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510713002/40001
Message was sent while issue was closed.
Description was changed from ========== mash: Add a couple of apptests for AcceleratorRegistrar. . Test that different AcceleratorRegistrars get different namespaces, and so can install accelerators with the same id. . Test that differentl registrars do not allow registering accelerators with the same event matcher. Previously landed in crrev.com/363719 with another test to make sure accelerators are removed when a handler is destroyed. But that test is flaky, so it is removed. BUG=548363, 568167 ========== to ========== mash: Add a couple of apptests for AcceleratorRegistrar. . Test that different AcceleratorRegistrars get different namespaces, and so can install accelerators with the same id. . Test that differentl registrars do not allow registering accelerators with the same event matcher. Previously landed in crrev.com/363719 with another test to make sure accelerators are removed when a handler is destroyed. But that test is flaky, so it is removed. BUG=548363, 568167 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== mash: Add a couple of apptests for AcceleratorRegistrar. . Test that different AcceleratorRegistrars get different namespaces, and so can install accelerators with the same id. . Test that differentl registrars do not allow registering accelerators with the same event matcher. Previously landed in crrev.com/363719 with another test to make sure accelerators are removed when a handler is destroyed. But that test is flaky, so it is removed. BUG=548363, 568167 ========== to ========== mash: Add a couple of apptests for AcceleratorRegistrar. . Test that different AcceleratorRegistrars get different namespaces, and so can install accelerators with the same id. . Test that differentl registrars do not allow registering accelerators with the same event matcher. Previously landed in crrev.com/363719 with another test to make sure accelerators are removed when a handler is destroyed. But that test is flaky, so it is removed. BUG=548363, 568167 Committed: https://crrev.com/80eae475b9325581067a7b743965cc315adca177 Cr-Commit-Position: refs/heads/master@{#364739} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/80eae475b9325581067a7b743965cc315adca177 Cr-Commit-Position: refs/heads/master@{#364739} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
