include/core/SkTDArray.h - Issue 1510683002: Add sk_careful_memcpy to catch undefined behavior in memcpy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkTDArray.h

Issue 1510683002: Add sk_careful_memcpy to catch undefined behavior in memcpy. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: reed Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkTDArray.h

diff --git a/include/core/SkTDArray.h b/include/core/SkTDArray.h

index 26c6c7f8956b6cb1cdd80eaad35af7ee774f47bd..b5332a2cc4aa26d3648ed869c81c0063195dcd9b 100644

--- a/include/core/SkTDArray.h

+++ b/include/core/SkTDArray.h

@@ -45,7 +45,7 @@ public:

SkTDArray<T> tmp(src.fArray, src.fCount);

this->swap(tmp);

} else {

- memcpy(fArray, src.fArray, sizeof(T) * src.fCount);

+ sk_careful_memcpy(fArray, src.fArray, sizeof(T) * src.fCount);

fCount = src.fCount;

}

« no previous file with comments | « include/core/SkTArray.h ('k') | include/core/SkTypes.h » ('j') | no next file with comments »