Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issue 1510663002: Reference configs variable from config help in GN (Closed)

Created:
5 years ago by brettw
Modified:
5 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reference configs variable from config help in GN This wasn't listed as a valid flag in the "gn help config" output. This also updates the style of the help message for "config" (newlines after headings, no colons). R=dpranke@chromium.org Committed: https://crrev.com/90cdb30cd5ddb90618f4dae90579bc8140ea9abb Cr-Commit-Position: refs/heads/master@{#363643}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M tools/gn/functions.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
brettw
5 years ago (2015-12-07 22:00:49 UTC) #1
Dirk Pranke
lgtm
5 years ago (2015-12-07 22:04:44 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510663002/1
5 years ago (2015-12-07 22:06:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510663002/1
5 years ago (2015-12-07 22:40:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 00:51:45 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-08 00:53:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90cdb30cd5ddb90618f4dae90579bc8140ea9abb
Cr-Commit-Position: refs/heads/master@{#363643}

Powered by Google App Engine
This is Rietveld 408576698