Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1510653002: add tests to demonstrate missing generic function subtype logic (Closed)

Created:
5 years ago by Jennifer Messerly
Modified:
5 years ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add tests to demonstrate missing generic function subtype logic R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/99b359837da7c5580b0b2863372397bf0224fcd6

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -3 lines) Patch
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 2 chunks +46 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
5 years ago (2015-12-07 21:39:27 UTC) #2
Leaf
lgtm https://codereview.chromium.org/1510653002/diff/1/pkg/analyzer/test/src/task/strong/checker_test.dart File pkg/analyzer/test/src/task/strong/checker_test.dart (right): https://codereview.chromium.org/1510653002/diff/1/pkg/analyzer/test/src/task/strong/checker_test.dart#newcode1390 pkg/analyzer/test/src/task/strong/checker_test.dart:1390: /*=/*severe:INVALID_METHOD_OVERRIDE*/S*/ then/*<S>*/(Object onValue(T t)) => null; you can ...
5 years ago (2015-12-07 21:44:54 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/1510653002/diff/1/pkg/analyzer/test/src/task/strong/checker_test.dart File pkg/analyzer/test/src/task/strong/checker_test.dart (right): https://codereview.chromium.org/1510653002/diff/1/pkg/analyzer/test/src/task/strong/checker_test.dart#newcode1390 pkg/analyzer/test/src/task/strong/checker_test.dart:1390: /*=/*severe:INVALID_METHOD_OVERRIDE*/S*/ then/*<S>*/(Object onValue(T t)) => null; On 2015/12/07 21:44:54, ...
5 years ago (2015-12-07 22:29:31 UTC) #4
Jennifer Messerly
5 years ago (2015-12-07 22:55:34 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
99b359837da7c5580b0b2863372397bf0224fcd6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698