Issue 151061: Regression: task manager icon for chrome is blank...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151061: Regression: task manager icon for chrome is blank... (Closed)

Created:
11 years, 5 months ago by cpu_(ooo_6.6-7.5)

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Regression: task manager icon for chrome is blank - During first run (confusing the newbie) - In other special situations when we show UI before the main chrome window is created BUG=14192 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19692

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	chrome/browser/browser_main.cc	View	1	4 chunks	+7 lines, -2 lines	0 comments	Download
	M	chrome/browser/views/frame/browser_view.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

11 years, 5 months ago (2009-06-30 23:08:53 UTC) #2

LGTM

http://codereview.chromium.org/151061/diff/1/3
File chrome/browser/browser_main.cc (right):

http://codereview.chromium.org/151061/diff/1/3#newcode385
Line 385: // their windows.
I would say that the delegate needs to be set before any UI is created so that
windows have the correct icon set.

Expand Messages | Collapse Messages