Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7436)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc

Issue 1510603003: [Media Router] Add UMA metrics for Media Router Dialog WebUI performance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
diff --git a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
index ce1da635092c325752fc17ed8006473a08bc6f76..a591adc1074035138443892010bf3e94268acc7a 100644
--- a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
+++ b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
@@ -29,6 +29,7 @@ const char kActOnIssue[] = "actOnIssue";
const char kCloseRoute[] = "closeRoute";
const char kCloseDialog[] = "closeDialog";
const char kReportSinkCount[] = "reportSinkCount";
+const char kOnInitialDataReceived[] = "onInitialDataReceived";
// JS function names.
const char kSetInitialData[] = "media_router.ui.setInitialData";
@@ -256,11 +257,16 @@ void MediaRouterWebUIMessageHandler::RegisterMessages() {
kReportSinkCount,
base::Bind(&MediaRouterWebUIMessageHandler::OnReportSinkCount,
base::Unretained(this)));
+ web_ui()->RegisterMessageCallback(
+ kOnInitialDataReceived,
+ base::Bind(&MediaRouterWebUIMessageHandler::OnInitialDataReceived,
+ base::Unretained(this)));
}
void MediaRouterWebUIMessageHandler::OnRequestInitialData(
const base::ListValue* args) {
DVLOG(1) << "OnRequestInitialData";
+ media_router_ui_->OnUIInitiallyLoaded();
mark a. foltz 2015/12/09 22:20:13 When is this called in the initialization flow? I
apacible 2015/12/09 23:19:55 This is called ASAP when the WebUI finishes loadin
base::DictionaryValue initial_data;
// "No Cast devices found?" Chromecast help center page.
@@ -395,6 +401,12 @@ void MediaRouterWebUIMessageHandler::OnReportSinkCount(
UMA_HISTOGRAM_COUNTS_100("MediaRouter.Ui.Device.Count", sink_count);
}
+void MediaRouterWebUIMessageHandler::OnInitialDataReceived(
+ const base::ListValue* args) {
+ DVLOG(1) << "OnInitialDataReceived";
+ media_router_ui_->OnUIInitialDataReceived();
+}
+
bool MediaRouterWebUIMessageHandler::ActOnIssueType(
const IssueAction::Type& action_type,
const base::DictionaryValue* args) {

Powered by Google App Engine
This is Rietveld 408576698