Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1510563002:
Reenables mash_wm_apptests (Closed)
|
Created:
5 years ago by sky Modified:
5 years ago Reviewers:
jam CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReenables mash_wm_apptests
I believe the reason for the flake was build targets weren't correctly
setup. I fixed that as part of disabling (
https://codereview.chromium.org/1497643002/ ). So, hopefully they just
work now.
BUG=559412
TEST=test only change
R=jam@chromium.org
TBR=jam@chromium.org
Committed: https://crrev.com/33ef981c2ad5aa83de6fdfb73e7c15e583cdc8c6
Cr-Commit-Position: refs/heads/master@{#363552}
Committed: https://crrev.com/75f9ba4267de856688905eddc6f1e27d7fa4ae05
Cr-Commit-Position: refs/heads/master@{#363950}
Patch Set 1 #
Messages
Total messages: 17 (6 generated)
The CQ bit was checked by sky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510563002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Reenables mash_wm_apptests I believe the reason for the flake was build targets weren't correctly setup. I fixed that as part of disabling ( https://codereview.chromium.org/1497643002/ ). So, hopefully they just work now. BUG=559412 TEST=test only change R=jam@chromium.org TBR=jam@chromium.org ========== to ========== Reenables mash_wm_apptests I believe the reason for the flake was build targets weren't correctly setup. I fixed that as part of disabling ( https://codereview.chromium.org/1497643002/ ). So, hopefully they just work now. BUG=559412 TEST=test only change R=jam@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/33ef981c2ad5aa83de6fdfb73e7c15e583cdc8c6 Cr-Commit-Position: refs/heads/master@{#363552} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/33ef981c2ad5aa83de6fdfb73e7c15e583cdc8c6 Cr-Commit-Position: refs/heads/master@{#363552}
Message was sent while issue was closed.
On 2015/12/07 19:48:01, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/33ef981c2ad5aa83de6fdfb73e7c15e583cdc8c6 > Cr-Commit-Position: refs/heads/master@{#363552} Broken on the FYI bots: ..."mash_wm_apptests.mojo' does not exist." https://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/b... https://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Windows... Running mojo:mash_wm_apptests... DEBUG:Command: E:\b\build\slave\chromium_mojo\build\src\out\Release\mojo_runner.exe --use-x11-test-config --override-use-gl-with-osmesa-for-tests --gtest_list_tests mojo:mash_wm_apptests DEBUG:Terminating the test for timeout. [ FAILED ] Command: E:\b\build\slave\chromium_mojo\build\src\out\Release\mojo_runner.exe --use-x11-test-config --override-use-gl-with-osmesa-for-tests --gtest_list_tests mojo:mash_wm_apptests ------------------------------------------------------------------------ [ERROR:application_manager.cc(246)] Library not started because library path 'E:/b/build/slave/chromium_mojo/build/src/out/Release/mash_wm_apptests/mash_wm_apptests.mojo' does not exist. ERROR: Test timeout after 10 seconds. ERROR: Test exited with code: -1073741510. ------------------------------------------------------------------------ [ FAILED ] mojo:mash_wm_apptests
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1505003002/ by sky@chromium.org. The reason for reverting is: Flaky..
Message was sent while issue was closed.
Description was changed from ========== Reenables mash_wm_apptests I believe the reason for the flake was build targets weren't correctly setup. I fixed that as part of disabling ( https://codereview.chromium.org/1497643002/ ). So, hopefully they just work now. BUG=559412 TEST=test only change R=jam@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/33ef981c2ad5aa83de6fdfb73e7c15e583cdc8c6 Cr-Commit-Position: refs/heads/master@{#363552} ========== to ========== Reenables mash_wm_apptests I believe the reason for the flake was build targets weren't correctly setup. I fixed that as part of disabling ( https://codereview.chromium.org/1497643002/ ). So, hopefully they just work now. BUG=559412 TEST=test only change R=jam@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/33ef981c2ad5aa83de6fdfb73e7c15e583cdc8c6 Cr-Commit-Position: refs/heads/master@{#363552} ==========
I reverted because it broke the FYI bot. Mike fixed this ( https://codereview.chromium.org/1506703003 ), so I'm relanding.
The CQ bit was checked by sky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510563002/1
lgtm
Message was sent while issue was closed.
Description was changed from ========== Reenables mash_wm_apptests I believe the reason for the flake was build targets weren't correctly setup. I fixed that as part of disabling ( https://codereview.chromium.org/1497643002/ ). So, hopefully they just work now. BUG=559412 TEST=test only change R=jam@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/33ef981c2ad5aa83de6fdfb73e7c15e583cdc8c6 Cr-Commit-Position: refs/heads/master@{#363552} ========== to ========== Reenables mash_wm_apptests I believe the reason for the flake was build targets weren't correctly setup. I fixed that as part of disabling ( https://codereview.chromium.org/1497643002/ ). So, hopefully they just work now. BUG=559412 TEST=test only change R=jam@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/33ef981c2ad5aa83de6fdfb73e7c15e583cdc8c6 Cr-Commit-Position: refs/heads/master@{#363552} ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Reenables mash_wm_apptests I believe the reason for the flake was build targets weren't correctly setup. I fixed that as part of disabling ( https://codereview.chromium.org/1497643002/ ). So, hopefully they just work now. BUG=559412 TEST=test only change R=jam@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/33ef981c2ad5aa83de6fdfb73e7c15e583cdc8c6 Cr-Commit-Position: refs/heads/master@{#363552} ========== to ========== Reenables mash_wm_apptests I believe the reason for the flake was build targets weren't correctly setup. I fixed that as part of disabling ( https://codereview.chromium.org/1497643002/ ). So, hopefully they just work now. BUG=559412 TEST=test only change R=jam@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/33ef981c2ad5aa83de6fdfb73e7c15e583cdc8c6 Cr-Commit-Position: refs/heads/master@{#363552} Committed: https://crrev.com/75f9ba4267de856688905eddc6f1e27d7fa4ae05 Cr-Commit-Position: refs/heads/master@{#363950} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/75f9ba4267de856688905eddc6f1e27d7fa4ae05 Cr-Commit-Position: refs/heads/master@{#363950} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
