Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1510553002: [Interpreter] Fixes PreviousBytecodeHelper to check if previous bytecode is in the same basic block. (Closed)

Created:
5 years ago by mythria
Modified:
5 years ago
Reviewers:
oth, rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Fixes PreviousBytecodeHelper to check if previous bytecode is in the same basic block. PreviousBytecodeHelper used to return Bytecode::kLast if the previous bytecode was not in the same basicblock. Changed it to be instantiated only when the previous bytecode is in the same basic block. BUG=v8:4280 LOG=N Committed: https://crrev.com/c03ac1e153efa01d1ed91eecfda22aefe1f453bf Cr-Commit-Position: refs/heads/master@{#32702}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Changes PreviousBytecodeHelper to be instantiated only when the last bytecode is in the same basicb… #

Total comments: 16

Patch Set 3 : Addressed review comments #

Patch Set 4 : Fixed a comment I forgot to fix in the last patch. #

Total comments: 4

Patch Set 5 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -29 lines) Patch
M src/interpreter/bytecode-array-builder.cc View 1 2 3 4 7 chunks +45 lines, -29 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
mythria
Could you please review my changes. This fixes one of the comments by Ross on ...
5 years ago (2015-12-08 09:09:31 UTC) #2
oth
Thanks, this change is okay, but I think it'd safer to do as described below. ...
5 years ago (2015-12-08 09:54:15 UTC) #3
mythria
Thanks for the comment Orion, code looks better now. Could you please take a look. ...
5 years ago (2015-12-08 11:24:43 UTC) #5
oth
Thanks Mythri, lgtm.
5 years ago (2015-12-08 11:54:20 UTC) #6
rmcilroy
https://codereview.chromium.org/1510553002/diff/20001/src/interpreter/bytecode-array-builder.cc File src/interpreter/bytecode-array-builder.cc (right): https://codereview.chromium.org/1510553002/diff/20001/src/interpreter/bytecode-array-builder.cc#newcode16 src/interpreter/bytecode-array-builder.cc:16: // in the same basicblock. /s/basicblock/basic block/ throughout, and ...
5 years ago (2015-12-08 13:43:02 UTC) #7
mythria
I fixed the comments. Could you please take a look. Thanks, Mythri https://codereview.chromium.org/1510553002/diff/20001/src/interpreter/bytecode-array-builder.cc File src/interpreter/bytecode-array-builder.cc ...
5 years ago (2015-12-08 14:53:29 UTC) #10
rmcilroy
lgtm, thanks. https://codereview.chromium.org/1510553002/diff/30002/src/interpreter/bytecode-array-builder.cc File src/interpreter/bytecode-array-builder.cc (right): https://codereview.chromium.org/1510553002/diff/30002/src/interpreter/bytecode-array-builder.cc#newcode23 src/interpreter/bytecode-array-builder.cc:23: DCHECK(array_builder_.last_bytecode_start_ == previous_bytecode_start_); DCHECK_EQ https://codereview.chromium.org/1510553002/diff/30002/src/interpreter/bytecode-array-builder.cc#newcode31 src/interpreter/bytecode-array-builder.cc:31: DCHECK(array_builder_.last_bytecode_start_ ...
5 years ago (2015-12-08 15:25:50 UTC) #11
mythria
Thanks for your reviews. https://codereview.chromium.org/1510553002/diff/30002/src/interpreter/bytecode-array-builder.cc File src/interpreter/bytecode-array-builder.cc (right): https://codereview.chromium.org/1510553002/diff/30002/src/interpreter/bytecode-array-builder.cc#newcode23 src/interpreter/bytecode-array-builder.cc:23: DCHECK(array_builder_.last_bytecode_start_ == previous_bytecode_start_); On 2015/12/08 ...
5 years ago (2015-12-09 09:10:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510553002/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510553002/70001
5 years ago (2015-12-09 10:35:33 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:70001)
5 years ago (2015-12-09 10:37:39 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-09 10:38:22 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c03ac1e153efa01d1ed91eecfda22aefe1f453bf
Cr-Commit-Position: refs/heads/master@{#32702}

Powered by Google App Engine
This is Rietveld 408576698