Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 151054: Enable the NNTP by default... (Closed)

Created:
11 years, 5 months ago by arv (Not doing code reviews)
Modified:
9 years, 3 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Enable the NNTP by default. This renames the command line flags a bit. --new-tab-page=path/to/file.html --old-new-tab-page BUG=13362 TEST=Launch chrome and you should see the new new tab page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19593

Patch Set 1 #

Patch Set 2 : Don't create a DownloadsDOMHandler if we cannot get the DownloadManager (unit testing) #

Patch Set 3 : Restructure the command line switches #

Patch Set 4 : Resolve merge conflicts #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -39 lines) Patch
M chrome/browser/dom_ui/new_tab_ui.h View 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 1 2 3 4 5 7 chunks +30 lines, -31 lines 0 comments Download
M chrome/common/chrome_switches.h View 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 3 4 5 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
arv (Not doing code reviews)
11 years, 5 months ago (2009-06-29 23:18:58 UTC) #1
Miranda Callahan
11 years, 5 months ago (2009-06-29 23:26:26 UTC) #2
LGTM.

On 2009/06/29 23:18:58, arv wrote:
>

Powered by Google App Engine
This is Rietveld 408576698