Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1510483002: Removes the Callee parameter from FunctionCallbackInfo. (Closed)

Created:
5 years ago by epertoso
Modified:
5 years ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Removes the Callee parameter from FunctionCallbackInfo. This will help us to instantiate AccessorPair's getters and setters only when they are needed. BUG= Committed: https://crrev.com/2fe34ebdcdee0f21b88daa4098a7918e91abb8fb Cr-Commit-Position: refs/heads/master@{#32759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -61 lines) Patch
M include/v8.h View 4 chunks +2 lines, -11 lines 0 comments Download
M src/arguments.h View 3 chunks +0 lines, -4 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/builtins.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
epertoso
5 years ago (2015-12-07 15:29:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510483002/1
5 years ago (2015-12-07 15:29:34 UTC) #4
jochen (gone - plz use gerrit)
v8.h lgtm
5 years ago (2015-12-07 15:30:28 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-07 16:07:36 UTC) #7
Toon Verwaest
awesome, lgtm
5 years ago (2015-12-08 11:42:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510483002/1
5 years ago (2015-12-08 11:53:05 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510483002/1
5 years ago (2015-12-10 14:22:05 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-10 15:03:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510483002/1
5 years ago (2015-12-10 15:06:49 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 15:36:25 UTC) #18
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2fe34ebdcdee0f21b88daa4098a7918e91abb8fb Cr-Commit-Position: refs/heads/master@{#32759}
5 years ago (2015-12-10 15:36:59 UTC) #20
epertoso
5 years ago (2015-12-11 10:19:41 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1520843002/ by epertoso@chromium.org.

The reason for reverting is: Need to figure out a better solution for this..

Powered by Google App Engine
This is Rietveld 408576698