Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Issue 1510453002: AudioPlayer: Fix the way to find a track element with given index. (Closed)

Created:
5 years ago by fukino
Modified:
5 years ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AudioPlayer: Fix the way to find a track element with given index. Current audio player uses shady dom, so '::shadow' in the selecter is invalid. Polymer's standard way to locate local dom should be used. BUG=554451 TEST=manually Committed: https://crrev.com/c66b6928de9b6bb20669ceecf8673480bea0ddc2 Cr-Commit-Position: refs/heads/master@{#363717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ui/file_manager/audio_player/elements/track_list.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
fukino
PTAL. Thanks!
5 years ago (2015-12-07 11:34:27 UTC) #2
yawano
lgtm. Thank you!
5 years ago (2015-12-07 12:23:15 UTC) #3
fukino
On 2015/12/07 12:23:15, yawano wrote: > lgtm. Thank you! Thank you!
5 years ago (2015-12-08 02:20:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510453002/1
5 years ago (2015-12-08 02:20:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 02:46:36 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-08 02:47:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c66b6928de9b6bb20669ceecf8673480bea0ddc2
Cr-Commit-Position: refs/heads/master@{#363717}

Powered by Google App Engine
This is Rietveld 408576698