Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: build/common.gypi

Issue 1510383002: .gypi and base change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/win/win_util.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 46ab6bf41b1db28f79bfd3544623dd00db11e79d..eab890cd937b5bb095481895ee18069ccdee200f 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3160,6 +3160,7 @@
'_SCL_SECURE_NO_DEPRECATE',
],
'msvs_disabled_warnings': [
+ # forcing value to bool 'true' or 'false' (performance warning)
4800,
],
'msvs_settings': {
@@ -5660,7 +5661,7 @@
# it's enabled. This will generally only be true for system-level
# installed Express users.
'msvs_disabled_warnings': [
- 4702,
+ 4702, # unreachable code
],
}],
],
@@ -5744,6 +5745,10 @@
# should work through these at some point -- they may be removed from
# the RTM release in the /W4 set.
4456, 4457, 4458, 4459,
+
+ # TODO(brucedawson): http://crbug.com/554200 4312 is a VS
+ # 2015 64-bit warning for integer to larger pointer
+ 4312,
],
'msvs_settings': {
'VCCLCompilerTool': {
« no previous file with comments | « base/win/win_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698