Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1510353003: Remove static initializer from BigIntegerUtils.cc (Closed)

Created:
5 years ago by Dirk Pranke
Modified:
5 years ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com, Nico, brettw, Lei Zhang
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove static initializer from BigIntegerUtils.cc which was being caused by including <iostream> instead of <ostream>. Since GN uses source_sets instead of static_libraries by default, the static initializer was making its way into Chrome, which was bad. R=tsepez@chromium.org BUG=559766 Committed: https://pdfium.googlesource.com/pdfium/+/0c92bed7ade20fe193dce0a481dad48e1be41622

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/bigint/BigIntegerUtils.hh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Dirk Pranke
I'm not sure if pdfium has trybots; I don't think it has a CQ. Though ...
5 years ago (2015-12-09 22:53:50 UTC) #2
Tom Sepez
LGTM. I'll take it from here.
5 years ago (2015-12-09 22:57:49 UTC) #3
Tom Sepez
5 years ago (2015-12-09 22:58:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c92bed7ade20fe193dce0a481dad48e1be41622 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698