third_party/WebKit/Source/core/layout/LayoutView.cpp - Issue 1510353002: PrintContext::pageProperty() shouldn't use 0 as page height.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 1510353002: PrintContext::pageProperty() shouldn't use 0 as page height. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: No need to call updateLayout() manually. PrintContext::begin() does it for us. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/printing/pageProperty-with-multicol-expected.txt ('k') | third_party/WebKit/Source/core/page/PrintContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutView.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutView.cpp b/third_party/WebKit/Source/core/layout/LayoutView.cpp

index 87c03483a421bcc65aacd97f0da39a769ec26ca6..fc1a96ed043106bdd5df131f6f0a404f182acf00 100644

--- a/third_party/WebKit/Source/core/layout/LayoutView.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutView.cpp

@@ -241,9 +241,7 @@ void LayoutView::layout()

if (shouldUsePrintingLayout()) {

m_minPreferredLogicalWidth = m_maxPreferredLogicalWidth = logicalWidth();

- // TODO(mstensho): Get rid of m_pageLogicalHeight zero check. Currently, pageProperty() in

- // PrintContext starts printing with zero height, so we have to cope for now.

- if (!m_fragmentationContext && m_pageLogicalHeight)

+ if (!m_fragmentationContext)

m_fragmentationContext = adoptPtr(new ViewFragmentationContext(*this));

} else if (m_fragmentationContext) {

m_fragmentationContext.clear();