third_party/WebKit/LayoutTests/printing/pageProperty-with-multicol.html - Issue 1510353002: PrintContext::pageProperty() shouldn't use 0 as page height.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/printing/pageProperty-with-multicol.html

Issue 1510353002: PrintContext::pageProperty() shouldn't use 0 as page height. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: code review Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/printing/pageProperty-with-multicol-expected.txt » ('j') | third_party/WebKit/Source/core/page/PrintContext.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/js-test.js"></script>

	3 <style>

	4 @page { margin:0 77px; }

	5 </style>

	6 <div style="-webkit-columns:3;">

	7 <br>

	8 <br>

	9 </div>

	10 <script>

	11 description("Test that special layout for pageProperty() doesn't crash or ca use trouble when the document contains multicol.");

	12 if (window.internals) {

	13 shouldBeEqualToString("internals.pageProperty('margin-left', 0)", "77");

	14 } else {

	15 testFailed("This test can be run only with window.internals enabled");

	16 }

	17 </script>

OLD	NEW