Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 151033003: Remove unneccessary assert (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3837 matching lines...) Expand 10 before | Expand all | Expand 10 after
3848 Representation representation = instr->representation(); 3848 Representation representation = instr->representation();
3849 3849
3850 HObjectAccess access = hinstr->access(); 3850 HObjectAccess access = hinstr->access();
3851 int offset = access.offset(); 3851 int offset = access.offset();
3852 3852
3853 if (access.IsExternalMemory()) { 3853 if (access.IsExternalMemory()) {
3854 ASSERT(!hinstr->NeedsWriteBarrier()); 3854 ASSERT(!hinstr->NeedsWriteBarrier());
3855 Register value = ToRegister(instr->value()); 3855 Register value = ToRegister(instr->value());
3856 if (instr->object()->IsConstantOperand()) { 3856 if (instr->object()->IsConstantOperand()) {
3857 ASSERT(value.is(rax)); 3857 ASSERT(value.is(rax));
3858 ASSERT(!access.representation().IsSpecialization());
3859 LConstantOperand* object = LConstantOperand::cast(instr->object()); 3858 LConstantOperand* object = LConstantOperand::cast(instr->object());
3860 __ store_rax(ToExternalReference(object)); 3859 __ store_rax(ToExternalReference(object));
3861 } else { 3860 } else {
3862 Register object = ToRegister(instr->object()); 3861 Register object = ToRegister(instr->object());
3863 __ Store(MemOperand(object, offset), value, representation); 3862 __ Store(MemOperand(object, offset), value, representation);
3864 } 3863 }
3865 return; 3864 return;
3866 } 3865 }
3867 3866
3868 Register object = ToRegister(instr->object()); 3867 Register object = ToRegister(instr->object());
(...skipping 1676 matching lines...) Expand 10 before | Expand all | Expand 10 after
5545 FixedArray::kHeaderSize - kPointerSize)); 5544 FixedArray::kHeaderSize - kPointerSize));
5546 __ bind(&done); 5545 __ bind(&done);
5547 } 5546 }
5548 5547
5549 5548
5550 #undef __ 5549 #undef __
5551 5550
5552 } } // namespace v8::internal 5551 } } // namespace v8::internal
5553 5552
5554 #endif // V8_TARGET_ARCH_X64 5553 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698