Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: chrome/renderer/resources/extension_process_bindings.js

Issue 151032: a few minor tweaks the bookmarks API:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2009 The chrome Authors. All rights reserved. 1 // Copyright (c) 2009 The chrome Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // ----------------------------------------------------------------------------- 5 // -----------------------------------------------------------------------------
6 // NOTE: If you change this file you need to touch renderer_resources.grd to 6 // NOTE: If you change this file you need to touch renderer_resources.grd to
7 // have your change take effect. 7 // have your change take effect.
8 // ----------------------------------------------------------------------------- 8 // -----------------------------------------------------------------------------
9 9
10 var chrome; 10 var chrome;
(...skipping 485 matching lines...) Expand 10 before | Expand all | Expand 10 after
496 type: "object", 496 type: "object",
497 properties: { 497 properties: {
498 title: chrome.types.optStr 498 title: chrome.types.optStr
499 } 499 }
500 }, 500 },
501 chrome.types.optFun 501 chrome.types.optFun
502 ]; 502 ];
503 503
504 // bookmark events 504 // bookmark events
505 505
506 // Sends (id, {title, url, parentId, index}) 506 // Sends (id, {title, url, parentId, index, dateAdded, dateGroupModified})
Matt Perry 2009/06/29 21:28:07 btw, the convention for optional is [foo] - see [c
Erik does not do reviews 2009/06/29 21:30:00 normally, I'd agree, but in this case, [] indicate
Matt Perry 2009/06/29 21:30:50 oh right.. that's unfortunate :(
507 // date values are milliseconds since the UTC epoch.
507 chrome.bookmarks.onAdded = new chrome.Event("bookmark-added"); 508 chrome.bookmarks.onAdded = new chrome.Event("bookmark-added");
508 509
509 // Sends ({parentId, index}) 510 // Sends (id, {parentId, index})
510 chrome.bookmarks.onRemoved = new chrome.Event("bookmark-removed"); 511 chrome.bookmarks.onRemoved = new chrome.Event("bookmark-removed");
511 512
512 // Sends (id, object) where object has list of properties that have changed. 513 // Sends (id, object) where object has list of properties that have changed.
513 // Currently, this only ever includes 'title'. 514 // Currently, this only ever includes 'title'.
514 chrome.bookmarks.onChanged = new chrome.Event("bookmark-changed"); 515 chrome.bookmarks.onChanged = new chrome.Event("bookmark-changed");
515 516
516 // Sends (id, {parentId, index, oldParentId, oldIndex}) 517 // Sends (id, {parentId, index, oldParentId, oldIndex})
517 chrome.bookmarks.onMoved = new chrome.Event("bookmark-moved"); 518 chrome.bookmarks.onMoved = new chrome.Event("bookmark-moved");
518 519
519 // Sends (id, [childrenIds]) 520 // Sends (id, [childrenIds])
(...skipping 13 matching lines...) Expand all
533 window.addEventListener('unload', function() { 534 window.addEventListener('unload', function() {
534 UnregisterExtension(extensionId); }, false); 535 UnregisterExtension(extensionId); }, false);
535 delete chrome.self.register_; 536 delete chrome.self.register_;
536 } 537 }
537 538
538 chrome.self.getViews = function() { 539 chrome.self.getViews = function() {
539 return GetViews(); 540 return GetViews();
540 } 541 }
541 })(); 542 })();
542 543
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698