Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 1510243002: client: Depend on compat (Closed)

Created:
5 years ago by Mark Mentovai
Modified:
5 years ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

client: Depend on compat The upcoming https://codereview.chromium.org/1513573005/ requires that std::move() in compat be available to callers in client. crashpad_client_mac.cc uses macros not available in all SDK versions. R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/8f3b0af2154a8a3d0e4a624a2f5dd474fc6114bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M client/client.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Mark Mentovai
5 years ago (2015-12-09 16:00:54 UTC) #2
scottmg
Maybe some motivation in the description? lgtm
5 years ago (2015-12-09 18:07:25 UTC) #3
Mark Mentovai
Updated description
5 years ago (2015-12-09 18:13:45 UTC) #5
Mark Mentovai
5 years ago (2015-12-09 22:31:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8f3b0af2154a8a3d0e4a624a2f5dd474fc6114bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698