Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1510233006: Revert of Reland: Fix incorrect sign in scroll and content box offset in absoluteToLocalPoint. (Closed)

Created:
5 years ago by johnme
Modified:
5 years ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: Fix incorrect sign in scroll and content box offset in absoluteToLocalPoint. (patchset #1 id:1 of https://codereview.chromium.org/1511183003/ ) Reason for revert: Caused the following tests to fail reliably on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/42251: [FAIL] CompositedLayerMappingTest.InterestRectOfIframeWithContentBoxOffset: [ RUN ] CompositedLayerMappingTest.InterestRectOfIframeWithContentBoxOffset [INFO:SkFontMgr_android_parser.cpp(597)] [SkFontMgr Android Parser] '/system/etc/fonts.xml' could not be opened [INFO:SkFontMgr_android_parser.cpp(597)] [SkFontMgr Android Parser] '/vendor/etc/fallback_fonts.xml' could not be opened ../../third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp:579: Failure Value of: actualRect.width() Actual: 500 Expected: IntRect(0, 0, 485, 7500).width() Which is: 485 [ FAILED ] CompositedLayerMappingTest.InterestRectOfIframeWithContentBoxOffset (43 ms) [FAIL] CompositedLayerMappingTest.InterestRectOfScrolledIframe: [ RUN ] CompositedLayerMappingTest.InterestRectOfScrolledIframe [INFO:SkFontMgr_android_parser.cpp(597)] [SkFontMgr Android Parser] '/system/etc/fonts.xml' could not be opened [INFO:SkFontMgr_android_parser.cpp(597)] [SkFontMgr Android Parser] '/vendor/etc/fallback_fonts.xml' could not be opened ../../third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp:556: Failure Value of: actualRect.width() Actual: 500 Expected: IntRect(0, 3500, 485, 4500).width() Which is: 485 [ FAILED ] CompositedLayerMappingTest.InterestRectOfScrolledIframe (50 ms) Original issue's description: > Reland: > > Fix incorrect sign in scroll and content box offset in absoluteToLocalPoint. > Also, refactored the tests a bit to share more code for iframes and reduce boilerplate. (https://codereview.chromium.org/1504363004) > > Now compiles with Oilpan. > > TBR=wangxianzhu@chromium.org > BUG=566238 > > Committed: https://crrev.com/437435aad459dd054b5c0e9a7e5b09ebcac6d902 > Cr-Commit-Position: refs/heads/master@{#364198} TBR=chrishtr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=566238 Committed: https://crrev.com/ba7324d50c2553999057cbe70795f403dd5ff207 Cr-Commit-Position: refs/heads/master@{#364353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -91 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTestHelper.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp View 2 chunks +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp View 6 chunks +23 lines, -54 lines 0 comments Download
M third_party/WebKit/Source/core/page/PrintContextTest.cpp View 5 chunks +38 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
johnme
Created Revert of Reland: Fix incorrect sign in scroll and content box offset in absoluteToLocalPoint.
5 years ago (2015-12-10 14:24:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510233006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510233006/1
5 years ago (2015-12-10 14:24:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 14:26:33 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-10 14:28:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba7324d50c2553999057cbe70795f403dd5ff207
Cr-Commit-Position: refs/heads/master@{#364353}

Powered by Google App Engine
This is Rietveld 408576698