DescriptionRevert of Reland: Fix incorrect sign in scroll and content box offset in absoluteToLocalPoint. (patchset #1 id:1 of https://codereview.chromium.org/1511183003/ )
Reason for revert:
Caused the following tests to fail reliably on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/42251:
[FAIL] CompositedLayerMappingTest.InterestRectOfIframeWithContentBoxOffset:
[ RUN ] CompositedLayerMappingTest.InterestRectOfIframeWithContentBoxOffset
[INFO:SkFontMgr_android_parser.cpp(597)] [SkFontMgr Android Parser] '/system/etc/fonts.xml' could not be opened
[INFO:SkFontMgr_android_parser.cpp(597)] [SkFontMgr Android Parser] '/vendor/etc/fallback_fonts.xml' could not be opened
../../third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp:579: Failure
Value of: actualRect.width()
Actual: 500
Expected: IntRect(0, 0, 485, 7500).width()
Which is: 485
[ FAILED ] CompositedLayerMappingTest.InterestRectOfIframeWithContentBoxOffset (43 ms)
[FAIL] CompositedLayerMappingTest.InterestRectOfScrolledIframe:
[ RUN ] CompositedLayerMappingTest.InterestRectOfScrolledIframe
[INFO:SkFontMgr_android_parser.cpp(597)] [SkFontMgr Android Parser] '/system/etc/fonts.xml' could not be opened
[INFO:SkFontMgr_android_parser.cpp(597)] [SkFontMgr Android Parser] '/vendor/etc/fallback_fonts.xml' could not be opened
../../third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp:556: Failure
Value of: actualRect.width()
Actual: 500
Expected: IntRect(0, 3500, 485, 4500).width()
Which is: 485
[ FAILED ] CompositedLayerMappingTest.InterestRectOfScrolledIframe (50 ms)
Original issue's description:
> Reland:
>
> Fix incorrect sign in scroll and content box offset in absoluteToLocalPoint.
> Also, refactored the tests a bit to share more code for iframes and reduce boilerplate. (https://codereview.chromium.org/1504363004)
>
> Now compiles with Oilpan.
>
> TBR=wangxianzhu@chromium.org
> BUG=566238
>
> Committed: https://crrev.com/437435aad459dd054b5c0e9a7e5b09ebcac6d902
> Cr-Commit-Position: refs/heads/master@{#364198}
TBR=chrishtr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=566238
Committed: https://crrev.com/ba7324d50c2553999057cbe70795f403dd5ff207
Cr-Commit-Position: refs/heads/master@{#364353}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|