Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1510233004: Inspect UI: Commit port forwarding changes after removing the rule. (Closed)

Created:
5 years ago by dgozman
Modified:
5 years ago
Reviewers:
pfeldman
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inspect UI: Commit port forwarding changes after removing the rule. BUG=568047 Committed: https://crrev.com/013ec016aa0be98a2976a875aec4f4225d8746bb Cr-Commit-Position: refs/heads/master@{#364279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/inspect/inspect.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
PTAL
5 years ago (2015-12-10 00:37:18 UTC) #2
pfeldman
lgtm
5 years ago (2015-12-10 02:31:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510233004/1
5 years ago (2015-12-10 02:35:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 04:51:23 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 04:52:26 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/013ec016aa0be98a2976a875aec4f4225d8746bb
Cr-Commit-Position: refs/heads/master@{#364279}

Powered by Google App Engine
This is Rietveld 408576698