Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 151023002: Move the rest of webkit/glue into content/common (Closed)

Created:
6 years, 10 months ago by tfarina
Modified:
6 years, 10 months ago
CC:
chromium-reviews, tzik, jam, nhiroki, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch
Visibility:
Public.

Description

Move the rest of webkit/glue into content/child One more step towards removing src/webkit/ BUG=265753 TEST=content_shell and content_unittests R=jochen@chromium.org,jam@chromium.org TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248367

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : fix #

Patch Set 4 : DEPS #

Total comments: 2

Patch Set 5 : #

Patch Set 6 : deps #

Patch Set 7 : rm webkit_glue.gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -598 lines) Patch
M build/all.gyp View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M components/sessions.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
M components/web_contents_delegate_android.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
A content/child/blink_glue.h View 1 2 3 4 1 chunk +23 lines, -0 lines 0 comments Download
A + content/child/blink_glue.cc View 1 2 3 4 2 chunks +5 lines, -6 lines 0 comments Download
M content/child/fileapi/webfilesystem_impl.cc View 1 2 3 4 4 chunks +3 lines, -3 lines 0 comments Download
A + content/child/simple_webmimeregistry_impl.h View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
A + content/child/simple_webmimeregistry_impl.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
A + content/child/webfileutilities_impl.h View 1 2 2 chunks +10 lines, -11 lines 0 comments Download
A + content/child/webfileutilities_impl.cc View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M content/content_child.gypi View 1 2 3 4 3 chunks +8 lines, -2 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 6 2 chunks +1 line, -6 lines 0 comments Download
M content/content_plugin.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M content/content_shell.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 5 chunks +0 lines, -5 lines 0 comments Download
M content/plugin/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 3 4 5 chunks +6 lines, -6 lines 0 comments Download
M content/test/test_webkit_platform_support.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M content/test/test_webkit_platform_support.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/utility/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/worker/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.cc View 1 2 3 4 5 chunks +4 lines, -4 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
D webkit/glue/simple_webmimeregistry_impl.h View 1 chunk +0 lines, -49 lines 0 comments Download
D webkit/glue/simple_webmimeregistry_impl.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D webkit/glue/webfileutilities_impl.h View 1 chunk +0 lines, -42 lines 0 comments Download
D webkit/glue/webfileutilities_impl.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D webkit/glue/webkit_glue.h View 1 chunk +0 lines, -24 lines 0 comments Download
D webkit/glue/webkit_glue.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D webkit/glue/webkit_glue.gyp View 1 2 3 4 5 6 1 chunk +0 lines, -17 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -133 lines 0 comments Download
D webkit/glue/webkit_glue_export.h View 1 2 3 4 5 6 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 54 (0 generated)
tfarina
I plan to clean up the webkit/glue/webkit_glue.gyp references in a follow up patch (after this ...
6 years, 10 months ago (2014-01-31 01:14:18 UTC) #1
jam
https://codereview.chromium.org/151023002/diff/20001/content/common/DEPS File content/common/DEPS (right): https://codereview.chromium.org/151023002/diff/20001/content/common/DEPS#newcode33 content/common/DEPS:33: "+third_party/WebKit/public/platform/WebURL.h", this and WebMimeegistry don't confirm to the comment ...
6 years, 10 months ago (2014-01-31 02:46:39 UTC) #2
tfarina
https://codereview.chromium.org/151023002/diff/20001/content/common/DEPS File content/common/DEPS (right): https://codereview.chromium.org/151023002/diff/20001/content/common/DEPS#newcode33 content/common/DEPS:33: "+third_party/WebKit/public/platform/WebURL.h", On 2014/01/31 02:46:39, jam wrote: > this and ...
6 years, 10 months ago (2014-01-31 12:52:49 UTC) #3
jam
lgtm with change https://codereview.chromium.org/151023002/diff/70001/content/common/blink_glue.h File content/common/blink_glue.h (right): https://codereview.chromium.org/151023002/diff/70001/content/common/blink_glue.h#newcode1 content/common/blink_glue.h:1: // Copyright 2013 The Chromium Authors. ...
6 years, 10 months ago (2014-01-31 17:36:02 UTC) #4
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-01-31 22:00:18 UTC) #5
tfarina
https://codereview.chromium.org/151023002/diff/70001/content/common/blink_glue.h File content/common/blink_glue.h (right): https://codereview.chromium.org/151023002/diff/70001/content/common/blink_glue.h#newcode1 content/common/blink_glue.h:1: // Copyright 2013 The Chromium Authors. All rights reserved. ...
6 years, 10 months ago (2014-01-31 22:01:14 UTC) #6
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 10 months ago (2014-01-31 22:01:20 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 22:01:23 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 22:01:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/151023002/160001
6 years, 10 months ago (2014-01-31 22:01:58 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 22:03:15 UTC) #11
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-01-31 22:03:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/151023002/220003
6 years, 10 months ago (2014-01-31 22:04:30 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-01-31 22:30:54 UTC) #14
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=47495
6 years, 10 months ago (2014-01-31 22:30:55 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 22:30:58 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 22:31:03 UTC) #17
tfarina
TBRing Darin for webkit/ changes.
6 years, 10 months ago (2014-01-31 23:42:48 UTC) #18
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-01-31 23:43:05 UTC) #19
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 10 months ago (2014-01-31 23:43:05 UTC) #20
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-01-31 23:43:05 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/151023002/220003
6 years, 10 months ago (2014-01-31 23:43:16 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-01 00:19:40 UTC) #23
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=219394
6 years, 10 months ago (2014-02-01 00:19:41 UTC) #24
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 00:19:42 UTC) #25
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 00:19:45 UTC) #26
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-01 00:20:54 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/151023002/220003
6 years, 10 months ago (2014-02-01 00:21:22 UTC) #28
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 10 months ago (2014-02-01 00:22:27 UTC) #29
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-01 00:22:28 UTC) #30
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 10 months ago (2014-02-01 00:22:28 UTC) #31
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 00:29:32 UTC) #32
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 00:29:35 UTC) #33
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 00:29:39 UTC) #34
tfarina
mac seems to not like the fact that libglue does not contain source code. I ...
6 years, 10 months ago (2014-02-01 00:29:49 UTC) #35
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 10 months ago (2014-02-01 02:25:32 UTC) #36
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-01 02:25:32 UTC) #37
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-01 02:25:33 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/151023002/720001
6 years, 10 months ago (2014-02-01 02:25:43 UTC) #39
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-01 03:10:11 UTC) #40
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) app_list_unittests, aura_unittests, browser_tests, compositor_unittests, content_browsertests, content_unittests, ...
6 years, 10 months ago (2014-02-01 03:10:12 UTC) #41
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 03:10:15 UTC) #42
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 03:10:22 UTC) #43
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-01 03:19:11 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/151023002/720001
6 years, 10 months ago (2014-02-01 03:19:23 UTC) #45
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 10 months ago (2014-02-01 14:41:00 UTC) #46
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 14:41:04 UTC) #47
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 14:41:08 UTC) #48
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 14:41:09 UTC) #49
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-01 14:41:57 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/151023002/720001
6 years, 10 months ago (2014-02-01 14:42:20 UTC) #51
commit-bot: I haz the power
Change committed as 248367
6 years, 10 months ago (2014-02-01 14:48:02 UTC) #52
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 14:48:07 UTC) #53
commit-bot: I haz the power
6 years, 10 months ago (2014-02-01 14:48:09 UTC) #54
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698