Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 15102013: add doc for Node.append (Closed)

Created:
7 years, 7 months ago by Jennifer Messerly
Modified:
7 years, 7 months ago
Reviewers:
Emily Fortuna, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 1 chunk +9 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/dom/docs/docs.json View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jennifer Messerly
anything else we want to say here?
7 years, 7 months ago (2013-05-13 20:59:49 UTC) #1
Emily Fortuna
I'd mention that if you need performant code, this is slightly more efficient than classes.add!
7 years, 7 months ago (2013-05-13 22:45:26 UTC) #2
Jennifer Messerly
On 2013/05/13 22:45:26, Emily Fortuna wrote: > I'd mention that if you need performant code, ...
7 years, 7 months ago (2013-05-13 23:15:22 UTC) #3
Emily Fortuna
lgtm. Thanks!
7 years, 7 months ago (2013-05-13 23:23:23 UTC) #4
Jennifer Messerly
7 years, 7 months ago (2013-05-13 23:32:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r22657 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698