Issue 1510193003: dart2js: Process arguments to direct invocations as if the target is known.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1510193003: dart2js: Process arguments to direct invocations as if the target is known. (Closed)

Created:
5 years ago by Kevin Millikin (Google)

Modified:
5 years ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js: Process arguments to direct invocations as if the target is known. When a method is invoked directly the target is known. Normalize the arguments based on the known target at CPS-translation time. If this is not done, then the call may go indirectly through a stub which is not actually generated. R=asgerf@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/12d79f91a3cb5dc01f78e2f3fd62f607fab95212

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart	View		2 chunks	+4 lines, -6 lines	0 comments	Download
	M	tests/co19/co19-dart2js.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Kevin Millikin (Google)

5 years ago (2015-12-09 15:27:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
12d79f91a3cb5dc01f78e2f3fd62f607fab95212 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages