Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1510173003: Enable SessionRestoreTest.RestoreWebUISettings test on Site Isolation FYI bot. (Closed)

Created:
5 years ago by nasko
Modified:
5 years ago
Reviewers:
Charlie Reis
CC:
chromium-reviews; site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable SessionRestoreTest.RestoreWebUISettings test on Site Isolation FYI bot. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation BUG=565600 R=creis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/f982412f62cf67b9b64c11c175d967b8a767f04c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M testing/buildbot/chromium.fyi.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
nasko
Hey Charlie, This is a follow up to enable the test for the MojoBindingsController fix ...
5 years ago (2015-12-09 18:18:55 UTC) #2
Charlie Reis
Don't forget to run a try job on linux_site_isolation. Otherwise LGTM!
5 years ago (2015-12-09 18:29:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510173003/1
5 years ago (2015-12-09 20:08:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/147277)
5 years ago (2015-12-09 21:45:29 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f982412f62cf67b9b64c11c175d967b8a767f04c Cr-Commit-Position: refs/heads/master@{#364168}
5 years ago (2015-12-09 21:49:07 UTC) #10
nasko
5 years ago (2015-12-09 21:49:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f982412f62cf67b9b64c11c175d967b8a767f04c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698