Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1510173002: Revert of Make Error.prototype.toString spec compliant; and fix various side-effect-free error printing metho… (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Make Error.prototype.toString spec compliant; and fix various side-effect-free error printing metho… (patchset #2 id:20001 of https://codereview.chromium.org/1507273002/ ) Reason for revert: [Sheriff] Breaks layout tests. Please rebase upstream first: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3334 Original issue's description: > Make Error.prototype.toString spec compliant; and fix various side-effect-free error printing methods > > R=yangguo@chromium.org > LOG=n > > Committed: https://crrev.com/5dffa35350d0f57402806e6bd87a914e1d5933e4 > Cr-Commit-Position: refs/heads/master@{#32695} TBR=yangguo@chromium.org,bmeurer@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/4c7e0f456fccbb838caf938e61853fc393c37ba5 Cr-Commit-Position: refs/heads/master@{#32700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -104 lines) Patch
M src/api.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M src/ast/scopes.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/contexts.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/execution.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/execution.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/isolate.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/js/messages.js View 10 chunks +84 lines, -71 lines 0 comments Download
M src/messages.h View 1 chunk +38 lines, -0 lines 0 comments Download
M src/messages.cc View 3 chunks +91 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M test/mjsunit/error-constructors.js View 2 chunks +33 lines, -8 lines 0 comments Download
M test/mjsunit/error-tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-352586.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-523308.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/stack-traces.js View 1 chunk +18 lines, -2 lines 0 comments Download
M test/test262/test262.status View 1 chunk +3 lines, -0 lines 0 comments Download
M test/webkit/toString-recursion.js View 1 chunk +3 lines, -0 lines 0 comments Download
M test/webkit/toString-recursion-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Michael Achenbach
5 years ago (2015-12-09 10:22:26 UTC) #1
Created Revert of Make Error.prototype.toString spec compliant; and fix various
side-effect-free error printing metho…

Powered by Google App Engine
This is Rietveld 408576698